Preferences.java: Set preferIPv6Addresses to default true #14285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This setup was introduced with #12917. |
dkocher
requested changes
Feb 28, 2023
core/src/main/java/ch/cyberduck/core/http/HttpConnectionPoolBuilder.java
Show resolved
Hide resolved
dkocher
reviewed
Feb 28, 2023
dkocher
reviewed
Feb 28, 2023
|
Need to check what behavior .NET WebRequest and TcpClient default to (on .NET 4.7.1)1 Otherwise, if Java-core defaults to IPv6, and our TcpReachability tests for IPv4, this may result in issues. Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 is now the majority IP version in various parts of the world:
As such, this PR sets the app behavior to prefer IPv6 connections by default.