Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net): Remove Default Execution Payload Envelope #36

Closed
refcell opened this issue Aug 26, 2024 · 0 comments · Fixed by #45
Closed

feat(net): Remove Default Execution Payload Envelope #36

refcell opened this issue Aug 26, 2024 · 0 comments · Fixed by #45
Labels
C-enhancement New feature or request

Comments

@refcell
Copy link
Collaborator

refcell commented Aug 26, 2024

Description

Remove the Default impl on the ExecutionPayloadEnvelope type.

This was introduced in #34 since the watch channel that's used to forward ExecutionPayloadEnvelope objects needs to be initialized with a default value for the object type passed into the channel. This ticket may require re-visiting the type of channel used in the net crate.
@refcell refcell added the C-enhancement New feature or request label Aug 26, 2024
@refcell refcell mentioned this issue Aug 26, 2024
Merged
@GrapeBaBa GrapeBaBa mentioned this issue Aug 27, 2024
Merged
refcell pushed a commit that referenced this issue Aug 27, 2024
@GrapeBaBa
Remove Default trait for ExecutionPayloadEnvelope. (#45)
4e349d6 
Fix #36 . This PR removed the unnecessary `Default` trait impl for
`ExecutionPayloadEnvelope`.
Replace the watch channel to std mpsc channel which no init value
needed.

Signed-off-by: Chen Kai <[email protected]>
@refcell refcell mentioned this issue Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Default trait for ExecutionPayloadEnvelope. optimism-java/op-rs
1 participant
@refcell