Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable readonly-access to Index from multiple threads. #6

Open
xivk opened this issue Mar 14, 2017 · 4 comments
Open

Enable readonly-access to Index from multiple threads. #6

xivk opened this issue Mar 14, 2017 · 4 comments
Assignees
Milestone

Comments

@xivk
Copy link
Contributor

xivk commented Mar 14, 2017

Related to:

itinero/routing#55

@xivk xivk self-assigned this Mar 14, 2017
@xivk xivk added this to the Version 2.0 milestone Aug 21, 2017
@xivk
Copy link
Contributor Author

xivk commented Feb 26, 2018

The problem is in the accessor implementation, we should use another implementation when working without a backing-stream:

https://github.com/itinero/reminiscence/blob/master/src/Reminiscence/IO/Accessors/MappedAccessorInt16.cs#L47

@juliusfriedman
Copy link

Is this related to itinero/routing#256 as well?

@juliusfriedman
Copy link

@xivk, #23 highlights a test which fails when accessing index in parallel, I tried to look into it but couldn't get far as of yet. I made my comments in the PR.

I am assuming this issue is related to that same thing or is this a new issue?

@juliusfriedman
Copy link

Also if the buffer is used couldn't there be a caching mechanism which checks to see if the value is already in the buffer and just read it from there rather than the stream? I am not quite sure how to implement this ... It might already be implemented to some degree as that unit test shows, after first enumeration the parallel tests don't exhibit the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants