Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Fastest works but Profile Shortest does not? #301

Open
juliusfriedman opened this issue Mar 3, 2020 · 4 comments
Open

Profile Fastest works but Profile Shortest does not? #301

juliusfriedman opened this issue Mar 3, 2020 · 4 comments

Comments

@juliusfriedman
Copy link

Using profile from: https://github.com/itinero/GTFS/blob/features/shapes/src/GTFS.Shapes/Osm/profiles/train.lua

From [email protected]% [41.8105,-87.76265]
To [email protected]% [41.616356,-87.3693]

Profile Shortest results in RouteNotFound exception while Profile Fastest has result with success:

LINESTRING (-87.762619018554688 41.810462951660156, -87.751045227050781 41.814109802246094, -87.74481201171875 41.816059112548828, -87.74359130859375 41.816444396972656, -87.743148803710938 41.816585540771484, -87.741142272949219 41.817211151123047, -87.739242553710938 41.817825317382812, -87.738555908203125 41.818046569824219, -87.738510131835938 41.818058013916016, -87.738075256347656 41.818195343017578, -87.737724304199219 41.818283081054688, -87.737380981445312 41.818374633789062, -87.736160278320312 41.818763732910156, -87.734794616699219 41.819171905517578, -87.725616455078125 41.822078704833984, -87.716751098632812 41.824867248535156, -87.715057373046875 41.825401306152344, -87.7149887084961 41.825420379638672, -87.714752197265625 41.825492858886719, -87.714401245117188 41.825584411621094, -87.714302062988281 41.825614929199219, -87.713981628417969 41.825687408447266, -87.713180541992188 41.825851440429688, -87.7126693725586 41.825935363769531, -87.712539672851562 41.825954437255859, -87.711959838867188 41.826026916503906, -87.711318969726562 41.826087951660156, -87.710700988769531 41.826118469238281, -87.707351684570312 41.826194763183594, -87.704643249511719 41.826244354248047, -87.7043685913086 41.826251983642578, -87.701667785644531 41.8263053894043, -87.694099426269531 41.826457977294922, -87.692794799804688 41.826484680175781, -87.6924819946289 41.826488494873047, -87.692390441894531 41.826492309570312, -87.692123413085938 41.826496124267578, -87.691459655761719 41.826507568359375, -87.6900634765625 41.8265380859375, -87.689956665039062 41.8265380859375, -87.6896743774414 41.826545715332031, -87.688385009765625 41.826572418212891, -87.6875228881836 41.826602935791016, -87.687255859375 41.826629638671875, -87.687019348144531 41.8266487121582, -87.686965942382812 41.826656341552734, -87.6869125366211 41.82666015625, -87.686805725097656 41.826412200927734, -87.6865463256836 41.825889587402344, -87.686347961425781 41.8255729675293, -87.6861801147461 41.8253173828125, -87.6860580444336 41.825149536132812, -87.685821533203125 41.824821472167969, -87.685554504394531 41.824459075927734, -87.685371398925781 41.824192047119141, -87.685111999511719 41.823787689208984, -87.684989929199219 41.823616027832031, -87.6845932006836 41.823036193847656, -87.6840591430664 41.822257995605469, -87.683998107910156 41.822174072265625, -87.683891296386719 41.822044372558594, -87.683784484863281 41.821922302246094, -87.683685302734375 41.821819305419922, -87.683586120605469 41.821727752685547, -87.683486938476562 41.821651458740234, -87.6832504272461 41.821495056152344, -87.682998657226562 41.821327209472656, -87.682441711425781 41.821010589599609, -87.68206787109375 41.820846557617188, -87.681846618652344 41.820762634277344, -87.681343078613281 41.820598602294922, -87.6808853149414 41.820476531982422, -87.680671691894531 41.820430755615234, -87.680343627929688 41.820381164550781, -87.679496765136719 41.820274353027344, -87.679428100585938 41.820266723632812, -87.6790542602539 41.820240020751953, -87.678634643554688 41.820247650146484, -87.678497314453125 41.82025146484375, -87.678153991699219 41.820278167724609, -87.677787780761719 41.8203010559082, -87.677505493164062 41.820308685302734, -87.6688232421875 41.820026397705078, -87.668373107910156 41.820049285888672, -87.667953491210938 41.820064544677734, -87.6675796508789 41.820049285888672, -87.667282104492188 41.820037841796875, -87.666961669921875 41.820037841796875, -87.6666488647461 41.820041656494141, -87.665946960449219 41.820026397705078, -87.6656265258789 41.8200569152832, -87.665390014648438 41.820110321044922, -87.665168762207031 41.820156097412109, -87.665046691894531 41.820171356201172, -87.6642837524414 41.820270538330078, -87.663749694824219 41.820358276367188, -87.663276672363281 41.820461273193359, -87.662971496582031 41.8205451965332, -87.662544250488281 41.820686340332031, -87.66180419921875 41.820930480957031, -87.6612319946289 41.821079254150391, -87.66082763671875 41.821212768554688, -87.660614013671875 41.8212776184082, -87.66046142578125 41.821315765380859, -87.660140991210938 41.821380615234375, -87.6598892211914 41.821426391601562, -87.65869140625 41.821533203125, -87.658409118652344 41.821575164794922, -87.65777587890625 41.821712493896484, -87.65618896484375 41.822090148925781, -87.655517578125 41.822135925292969, -87.64794921875 41.822231292724609, -87.647010803222656 41.822216033935547, -87.646774291992188 41.822189331054688, -87.6463851928711 41.822097778320312, -87.6456527709961 41.821849822998047, -87.645156860351562 41.821697235107422, -87.644882202148438 41.821647644042969, -87.644699096679688 41.821628570556641, -87.644325256347656 41.821617126464844, -87.643989562988281 41.821617126464844, -87.642974853515625 41.821632385253906, -87.642692565917969 41.821636199951172, -87.641571044921875 41.821701049804688, -87.6404800415039 41.821701049804688, -87.639106750488281 41.821704864501953, -87.638519287109375 41.821678161621094, -87.638175964355469 41.821628570556641, -87.637832641601562 41.821540832519531, -87.637626647949219 41.821468353271484, -87.637413024902344 41.821369171142578, -87.637054443359375 41.821140289306641, -87.636909484863281 41.821014404296875, -87.6365966796875 41.820632934570312, -87.636390686035156 41.820163726806641, -87.636314392089844 41.819892883300781, -87.63629150390625 41.8197135925293, -87.636238098144531 41.819236755371094, -87.6362075805664 41.818996429443359, -87.636093139648438 41.81793212890625, -87.636070251464844 41.817680358886719, -87.636070251464844 41.817592620849609, -87.636077880859375 41.817359924316406, -87.6361083984375 41.816959381103516, -87.636100769042969 41.816802978515625, -87.635971069335938 41.811672210693359, -87.635948181152344 41.810653686523438, -87.63592529296875 41.809890747070312, -87.635917663574219 41.8092155456543, -87.635902404785156 41.808639526367188, -87.635871887207031 41.807338714599609, -87.635726928710938 41.801399230957031, -87.635612487792969 41.800693511962891, -87.63555908203125 41.7994270324707, -87.635498046875 41.797138214111328, -87.635498046875 41.796722412109375, -87.635505676269531 41.796405792236328, -87.6355209350586 41.796134948730469, -87.635513305664062 41.795932769775391, -87.635505676269531 41.795757293701172, -87.635490417480469 41.795516967773438, -87.635482788085938 41.795318603515625, -87.635490417480469 41.795207977294922, -87.6354751586914 41.794853210449219, -87.635467529296875 41.794582366943359, -87.635452270507812 41.794021606445312, -87.635444641113281 41.793693542480469, -87.63543701171875 41.793327331542969, -87.635414123535156 41.792728424072266, -87.635391235351562 41.791812896728516, -87.635368347167969 41.790927886962891, -87.635360717773438 41.790729522705078, -87.635330200195312 41.789569854736328, -87.63531494140625 41.788875579833984, -87.635307312011719 41.788795471191406, -87.635292053222656 41.788047790527344, -87.635269165039062 41.787288665771484, -87.635269165039062 41.787086486816406, -87.635246276855469 41.786235809326172, -87.635223388671875 41.7854118347168, -87.635215759277344 41.785213470458984, -87.635208129882812 41.784908294677734, -87.63519287109375 41.78472900390625, -87.635162353515625 41.7845573425293, -87.635116577148438 41.784358978271484, -87.635055541992188 41.784183502197266, -87.6349105834961 41.783851623535156, -87.6347885131836 41.783645629882812, -87.634651184082031 41.783451080322266, -87.634513854980469 41.783279418945312, -87.634292602539062 41.783058166503906, -87.634117126464844 41.782905578613281, -87.633918762207031 41.782752990722656, -87.633758544921875 41.782642364501953, -87.6334457397461 41.7824592590332, -87.632804870605469 41.7821159362793, -87.6325454711914 41.781978607177734, -87.6319808959961 41.781688690185547, -87.630043029785156 41.780689239501953, -87.62908935546875 41.780193328857422, -87.6288833618164 41.780086517333984, -87.6280288696289 41.779636383056641, -87.627487182617188 41.779384613037109, -87.627113342285156 41.779209136962891, -87.626602172851562 41.7789421081543, -87.625732421875 41.778530120849609, -87.625473022460938 41.778392791748047, -87.6252212524414 41.77825927734375, -87.625015258789062 41.778156280517578, -87.623893737792969 41.777580261230469, -87.623443603515625 41.7773323059082, -87.622978210449219 41.777042388916016, -87.622726440429688 41.7768669128418, -87.6185302734375 41.773868560791016, -87.609115600585938 41.7671012878418, -87.607925415039062 41.766231536865234, -87.598892211914062 41.759735107421875, -87.596717834472656 41.758182525634766, -87.5959701538086 41.757648468017578, -87.595268249511719 41.757144927978516, -87.594589233398438 41.756641387939453, -87.593833923339844 41.756099700927734, -87.59356689453125 41.755905151367188, -87.592155456542969 41.754890441894531, -87.5705337524414 41.739337921142578, -87.5555191040039 41.728538513183594, -87.552619934082031 41.726398468017578, -87.551544189453125 41.725616455078125, -87.551261901855469 41.725418090820312, -87.5510025024414 41.725227355957031, -87.5508041381836 41.7250862121582, -87.550308227539062 41.724739074707031, -87.548881530761719 41.723804473876953, -87.5486831665039 41.723663330078125, -87.5484619140625 41.723506927490234, -87.548011779785156 41.723178863525391, -87.547561645507812 41.722858428955078, -87.547294616699219 41.722671508789062, -87.5465087890625 41.722103118896484, -87.545639038085938 41.721473693847656, -87.545196533203125 41.721157073974609, -87.544891357421875 41.720928192138672, -87.544486999511719 41.720619201660156, -87.543975830078125 41.720222473144531, -87.543548583984375 41.719913482666016, -87.543380737304688 41.719791412353516, -87.542488098144531 41.719142913818359, -87.542160034179688 41.718910217285156, -87.541839599609375 41.718681335449219, -87.540946960449219 41.718048095703125, -87.540168762207031 41.717479705810547, -87.539505004882812 41.716999053955078, -87.539237976074219 41.716812133789062, -87.538833618164062 41.716537475585938, -87.5381851196289 41.716094970703125, -87.537322998046875 41.715484619140625, -87.535453796386719 41.714088439941406, -87.534591674804688 41.713405609130859, -87.533729553222656 41.712684631347656, -87.529541015625 41.708827972412109, -87.526168823242188 41.705680847167969, -87.524826049804688 41.704448699951172, -87.524398803710938 41.7040901184082, -87.524246215820312 41.703975677490234, -87.524085998535156 41.703861236572266, -87.523818969726562 41.70367431640625, -87.523017883300781 41.703189849853516, -87.5220947265625 41.702728271484375, -87.5211181640625 41.702262878417969, -87.5208969116211 41.702152252197266, -87.519981384277344 41.701652526855469, -87.51953125 41.701358795166016, -87.519073486328125 41.701015472412109, -87.518829345703125 41.700809478759766, -87.51666259765625 41.698837280273438, -87.51611328125 41.698307037353516, -87.5156478881836 41.697799682617188, -87.515373229980469 41.697444915771484, -87.514701843261719 41.696514129638672, -87.514396667480469 41.696125030517578, -87.51409912109375 41.69580078125, -87.5133056640625 41.6950798034668, -87.512893676757812 41.694770812988281, -87.512649536132812 41.694602966308594, -87.512100219726562 41.694236755371094, -87.510780334472656 41.693412780761719, -87.508529663085938 41.691978454589844, -87.50677490234375 41.690879821777344, -87.504043579101562 41.689159393310547, -87.5010986328125 41.687309265136719, -87.500175476074219 41.686729431152344, -87.498367309570312 41.685585021972656, -87.4979476928711 41.685340881347656, -87.497283935546875 41.685024261474609, -87.496917724609375 41.684883117675781, -87.4964828491211 41.684738159179688, -87.4942855834961 41.684181213378906, -87.493545532226562 41.683952331542969, -87.493156433105469 41.683799743652344, -87.49267578125 41.683578491210938, -87.4916763305664 41.683036804199219, -87.490364074707031 41.68231201171875, -87.489547729492188 41.681861877441406, -87.480598449707031 41.676895141601562, -87.4766616821289 41.674716949462891, -87.4742202758789 41.673427581787109, -87.4656753540039 41.668922424316406, -87.464546203613281 41.668296813964844, -87.462760925292969 41.667205810546875, -87.461929321289062 41.666645050048828, -87.45721435546875 41.663375854492188, -87.455551147460938 41.6622428894043, -87.454879760742188 41.66180419921875, -87.4544677734375 41.661544799804688, -87.454177856445312 41.661354064941406, -87.453315734863281 41.660770416259766, -87.4524917602539 41.660202026367188, -87.452117919921875 41.659946441650391, -87.451942443847656 41.659824371337891, -87.451454162597656 41.659481048583984, -87.449424743652344 41.658012390136719, -87.449272155761719 41.657905578613281, -87.448715209960938 41.657493591308594, -87.448028564453125 41.657005310058594, -87.446487426757812 41.655933380126953, -87.445106506347656 41.654983520507812, -87.4448013305664 41.654777526855469, -87.444419860839844 41.654514312744141, -87.444183349609375 41.654350280761719, -87.443771362304688 41.654071807861328, -87.443359375 41.653835296630859, -87.44305419921875 41.65362548828125, -87.4420394897461 41.652908325195312, -87.441352844238281 41.652385711669922, -87.440155029296875 41.651435852050781, -87.4391098022461 41.650543212890625, -87.438064575195312 41.649612426757812, -87.435173034667969 41.6470832824707, -87.4291000366211 41.641761779785156, -87.427482604980469 41.640411376953125, -87.427040100097656 41.640056610107422, -87.426826477050781 41.639892578125, -87.426284790039062 41.639476776123047, -87.4255599975586 41.638946533203125, -87.425094604492188 41.638607025146484, -87.42498779296875 41.638530731201172, -87.423988342285156 41.637916564941406, -87.4239501953125 41.637893676757812, -87.423744201660156 41.63775634765625, -87.423698425292969 41.637722015380859, -87.423568725585938 41.637638092041016, -87.423538208007812 41.637615203857422, -87.42230224609375 41.636772155761719, -87.421180725097656 41.636039733886719, -87.421173095703125 41.636035919189453, -87.420417785644531 41.635570526123047, -87.418319702148438 41.634384155273438, -87.4169692993164 41.633674621582031, -87.416015625 41.633197784423828, -87.413825988769531 41.632171630859375, -87.411788940429688 41.631290435791016, -87.4102554321289 41.63067626953125, -87.410018920898438 41.630580902099609, -87.40966796875 41.630474090576172, -87.409355163574219 41.630363464355469, -87.409065246582031 41.630268096923828, -87.408256530761719 41.630035400390625, -87.407783508300781 41.6298828125, -87.40704345703125 41.629623413085938, -87.4065933227539 41.629486083984375, -87.404937744140625 41.629070281982422, -87.404571533203125 41.628974914550781, -87.404220581054688 41.628856658935547, -87.394050598144531 41.625240325927734, -87.393272399902344 41.624961853027344, -87.392974853515625 41.6248664855957, -87.392669677734375 41.624797821044922, -87.392326354980469 41.624717712402344, -87.391899108886719 41.624618530273438, -87.391120910644531 41.624439239501953, -87.390739440917969 41.624351501464844, -87.390121459960938 41.624225616455078, -87.389732360839844 41.624191284179688, -87.389167785644531 41.624202728271484, -87.3887939453125 41.624221801757812, -87.388740539550781 41.624225616455078, -87.3878173828125 41.624202728271484, -87.387413024902344 41.624149322509766, -87.386993408203125 41.624042510986328, -87.38677978515625 41.62396240234375, -87.38568115234375 41.623489379882812, -87.383796691894531 41.622772216796875, -87.383674621582031 41.622718811035156, -87.38360595703125 41.622684478759766, -87.383224487304688 41.622493743896484, -87.382781982421875 41.622268676757812, -87.382011413574219 41.6218376159668, -87.380256652832031 41.620697021484375, -87.379913330078125 41.6204948425293, -87.379356384277344 41.620197296142578, -87.378486633300781 41.619766235351562, -87.377525329589844 41.619312286376953, -87.3769302368164 41.619075775146484, -87.369300842285156 41.616355895996094)

@xivk
Copy link
Contributor

xivk commented Mar 3, 2020

It is strange this fails, I'll try to have a look, still really busy though so not sure when I will get to it.

I can tell you, for sure that because there is only one constant speed set, shortest and fastest in this case should always give the same route.

@juliusfriedman
Copy link
Author

juliusfriedman commented Mar 3, 2020

What's also strange is that this lua profile on shortest can find a route...
locomotive .lua.txt

@juliusfriedman
Copy link
Author

juliusfriedman commented Mar 7, 2020

Seems to be somewhat fixed via #302

@juliusfriedman
Copy link
Author

juliusfriedman commented Mar 9, 2020

Not quite fixed by #302 as I am getting the same issue when using the SimpleTrain but in a different route, Shortest seems to fail but Fastest resolved.

As there is no difference in this case I am not sure where to look directly but I will try to take a look when I have time, the Locomotive profile doesn't seem to have this issue as it resolved points and calculates on all profiles (fastest, shortest and classifications) where as SimpleTrain will resolve points on Shortest but not Calculate a route for unknown reasons. (Although in difference cases that it did before)

The points which are failing to route under shortest this time is:

Latitude=30.4608906,Longitude=-91.1754958
Latitude=30.4219282,Longitude=-91.1505773
Latitude=30.4547893,Longitude=-91.1744733
Latitude=30.471294,Longitude=-91.1752051}
Latitude=30.4657931,Longitude=-91.1752237
Latitude=30.4607259,Longitude=-91.1750374
Latitude=30.4609047,Longitude=-91.1754881
Latitude=30.1249238,Longitude=-90.7717801
Latitude=30.2347364,Longitude=-90.9131393
Latitude=30.3592879,Longitude=-91.0419534
Latitude=30.3895487,Longitude=-91.0944052
Latitude=30.3592879,Longitude=-91.0419534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants