Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do something clever for tag-triggered jobs/workflows #12

Open
iynere opened this issue Jan 4, 2019 · 4 comments
Open

do something clever for tag-triggered jobs/workflows #12

iynere opened this issue Jan 4, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@iynere
Copy link
Owner

iynere commented Jan 4, 2019

tag-triggered jobs / workflows don't technically have a branch, although circle in-essence treats them as if they do—there's some strange edge case behavior here....

@sibelius
Copy link

the commit range could be based on the latest tag before the current tag, example:

from tag v1.0.0 to v1.0.1

@iynere
Copy link
Owner Author

iynere commented May 29, 2019

hmmm, interesting thought @sibelius i don't think that would fit most of the use cases for git tag-triggered jobs/workflows, at least not in my experience—when i push tags to trigger jobs, i'm rarely interested in what's changed since the previous tag

@sibelius
Copy link

we use tag to track our releases

this could be useful to track which microservices to deploy based on the changes from the last release

@iynere
Copy link
Owner Author

iynere commented May 29, 2019

oh totally, that makes a lot of sense to me. like, compare the source @ the current tag to the source @ the previous tag.

if you have a sense of how we'd implement that, feel free to submit a PR @sibelius & thank you !

@iynere iynere added the enhancement New feature or request label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants