Add an Arduino version #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! I appreciate it! However, I'm not sure yet if I want to add this complexity to this project. Especially because I have no experience with Arduino (or any microcontroller) development at all and it seems to be quite easy to modify the code to make it work on Arduino. And I need to see how this would be tested on a CI (Travis or GitHub Actions), unless you are also willing to add something to the PR to enable this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the C++11 version, and is related to Issue #15.
While the Arduino does not have the standard library, it has its own String version. The
F(...)macro wrapping the C strings tells the microcontroller to store the data in flash instead of permanently using a massive portion of RAM.Similarly, due to how the system works, inlining
reasonPhrasewould cause the strings to be copied every time the function was called.Modern build tools like PlatformIO automatically detect, compile, and link the cpp file without any special handling needed.