Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the log output directory XDG compliant or configurable #402

Open
Javyre opened this issue Dec 14, 2018 · 3 comments · May be fixed by #967
Open

Make the log output directory XDG compliant or configurable #402

Javyre opened this issue Dec 14, 2018 · 3 comments · May be fixed by #967
Labels
feature good first issue Potentially simple issue to solve for new contributors

Comments

@Javyre
Copy link

Javyre commented Dec 14, 2018

I noticed that the path to the log output for jack is hardcoded:

jack2/dbus/jackdbus.c

Line 713 in cc8576a

if (!(xdg_log_home = pathname_cat(home_dir, DEFAULT_XDG_LOG))) goto fail;

I know there is no $XDG_LOG_HOME in the standard so I suggest making it configurable through some custom environment variable like $JACKLOG or something and then falling back on $XDG_DATA_HOME/jack or $XDG_RUNTIME_DIR

spec:
https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
@7890 7890 added feature good first issue Potentially simple issue to solve for new contributors labels Jan 14, 2019
dpzmick added a commit to dpzmick/jack2 that referenced this issue May 14, 2019
@dpzmick
make jackdbus logdir configurable (closes jackaudio#402)
1e14331
@piegamesde piegamesde mentioned this issue May 16, 2020
Open
@rhysday
Copy link

rhysday commented May 16, 2020 •
edited
Loading

Sorry I'm not a dev. What enviroment variable can I use to change the jackdrc path? or can I just put jackdrc into $XDG_CONFIG_HOME? or $XDG_CONFIG_HOME/jack?

@piegamesde
Copy link

Currently, the recommended way to store logs is either in $XDG_DATA_HOME or $XDG_CACHE_HOME. The Debian Wiki suggests an extension to the spec that proposes $XDG_STATE_HOME for this purpose, which I use for my projects as well. (I can put up some links to this if anyone's still interested in this.)

@BrunoVernay
Copy link
Contributor

"Usually" (as for the majority of apps on my system) logs simply go to XDG_DATA_HOME ($HOME/.local/share)

A few use $XDG_CACHE_HOME ($HOME/.cache/)

Any of the two would be way better than the current $HOME/.log/ which is as good as $HOME/.jack-logs/

@piegamesde piegamesde mentioned this issue Nov 9, 2020
Open
@keithbowes keithbowes linked a pull request Jan 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue Potentially simple issue to solve for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use XDG_STATE_HOME for jackdbus logs keithbowes/jack2
5 participants
@BrunoVernay @7890 @piegamesde @Javyre @rhysday