cargo-hf2 parses --vid and --pid without bias towards hex

[gkelly]

Most (all?) times that USB VID/PID values are written they are written as hexadecimal without the 0x prefix. This is confusing when using cargo hf2 because you end up with errors like:

$ cargo hf2 --vid 2886 --pid 002f --example blink
error: Invalid value for '--pid <pid>': invalid digit found in string

udev rules and lsusb both print these values without the 0x prefix, so it feels unergonomic to reject those same values here.

[jacobrosenthal]

I think it does parse hex but must need the 0x

…

On Sun, Apr 12, 2020, 5:39 PM Garret Kelly ***@***.***> wrote: Most (all?) times that USB VID/PID values are written they are written as hexadecimal without the 0x prefix. This is confusing when using cargo hf2 because you end up with errors like: $ cargo hf2 --vid 2886 --pid 002f --example blink error: Invalid value for '--pid <pid>': invalid digit found in string udev rules and lsusb both print these values without the 0x prefix, so it feels unergonomic to reject those same values here. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADPI5A5ZNMXD6DR5RFAEADRMJNMHANCNFSM4MGT6XBQ> .

[gkelly]

I think it does parse hex but must need the 0x

Sorry, I didn't mention that but yes it definitely does do the right thing if you put the base prefix on the arguments.