Remove usages of GetStorageFactory

[mahadzaryab1]

We have two remaining usages of jaegerstorage.GetStorageFactory, which provide the v1 factory:

• https://github.com/jaegertracing/jaeger/blob/main/cmd/jaeger/internal/integration/storagecleaner/extension.go#L54
• https://github.com/jaegertracing/jaeger/blob/main/cmd/jaeger/internal/extension/remotesampling/extension.go#L192

We want to remove these and find a way to get the same functionality using the v2 factory.

[ADI-ROXX]

@mahadzaryab1 Can you provide some resources to get started on v2. Also, what are the changes from v1 to v2

[osamaahmed17]

@mahadzaryab1, I am interested in this issue. Can you assign it to me?

[ary82]

Hey @mahadzaryab1, I'm fairly new to the repository. Is this issue open for contributions?

I read a bit through the v2 proposal and the parent issue. From what I understand, we want to change jaegerstorage.GetStorageFactory to jaegerstorage.GetTraceStoreFactory, which provides the v2 Factory through the storage v1adapter, and implement storage.Purger and storage.SamplingStoreFactory in v1adapter.Factory.
We should be able to do this by defining the required methods and casting the v1 Factory to the necessary interfaces and calling their methods. For example, for Purger, in v1adapter/factory:

func (f *Factory) Purge(ctx context.Context) error {
	p, ok := f.ss.(storage_v1.Purger)
	if !ok {
	// storage backend doesn't implement Purger
	}
	err := p.Purge(ctx)
	return err
}

Am I on the right path?

[theNextEren]

hey @mahadzaryab1 but storage_v1 dosent have a samplingstore, and we can encapsulate both the depstore.Factory and tracestore.Factory into a struct to use the CreateDependencyReader ,CreateTraceReader and CreateTraceWriter in the jaegarstorage/extension.go WDYS

[ary82]

Hey @yurishkuro, I'm trying to migrate the Sampling/Purger apis to v2. For samplingstore, the interface in question is SamplingStoreFactory, currently in internal/storage/v1/factory.go. Since its implementation needs the v1/api/samplingstore package, do we also want to move this package to v2?

If so, every storage backend implementing this would need to import v2 anyways, so the v1 type aliases would be unused as we would need to import the v2 samplingstore models to implement the interfaces

If not, after moving SamplingStoreFactory to v2, we need to import v1/api/samplingstore in v2, which does not seem favorable

What are your thoughts?