Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing N2 vocab #12

Closed
jamesrm9235 opened this issue Jun 14, 2023 · 3 comments · Fixed by #14
Closed

Missing N2 vocab #12

jamesrm9235 opened this issue Jun 14, 2023 · 3 comments · Fixed by #14

Comments

@jamesrm9235
Copy link

Hello,

I found 158 missing N2 words. I discovered them when merging this repo's N2 deck with my own. I'm attaching a TSV file containing the words.

If accepted, I can add them to the n2.csv through a pull request.

missing.txt

@jamsinclair
Copy link
Owner

Thanks @jamesrm9235! The sources for this repo are years old so it's very likely there may be some missing or out-of-date words.

Do you have a source or link to where you got your deck or these words from? I just want to make sure we have reputable source so people can focus on what is necessary for the test.

@jamesrm9235
Copy link
Author

No problem! I still found a lot of new words to add to my own deck.

I referred to jisho.org. The words are tagged "jlpt n2" according to the site. I'm attaching an updated file with links for each word.

missing-with-ref-link.txt

@jamsinclair
Copy link
Owner

jamsinclair commented Jul 16, 2023

Thanks for confirming that @jamesrm9235.

I've added the new words in #14.

I also sorted the CSV notes which makes it hard to see the changes. To easily see and verify the new words that were added you'll want to refer to this commit 7434abc

Feel free to re-open if I missed something and thanks again! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants