Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current examples that can not be compiled #40

Open
10 tasks
mattiasdrp opened this issue Sep 19, 2023 · 2 comments
Open
10 tasks

Current examples that can not be compiled #40

mattiasdrp opened this issue Sep 19, 2023 · 2 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@mattiasdrp
Copy link

mattiasdrp commented Sep 19, 2023

  • accordion
File "examples/accordion/dune", line 3, characters 2-23:
3 |   bonsai_web_ui_gallery)
      ^^^^^^^^^^^^^^^^^^^^^
Error: Library "bonsai_web_ui_gallery" not found.

File "examples/accordion/dune", line 4, characters 62-70:
4 |  (preprocess (pps ppx_jane js_of_ocaml-ppx ppx_bonsai ppx_css ppx_demo)))
                                                                  ^^^^^^^^
Error: Library "ppx_demo" not found.
  • bonsai_view
File "examples/bonsai_view/dune", line 2, characters 64-75:
2 |  (libraries bonsai_web bonsai_web_ui_form bonsai_web_ui_gallery auto_reload)
                                                                    ^^^^^^^^^^^
Error: Library "auto_reload" not found.

File "examples/bonsai_view/dune", line 3, characters 62-70:
3 |  (preprocess (pps ppx_jane js_of_ocaml-ppx ppx_bonsai ppx_css ppx_demo)))
                                                                  ^^^^^^^^
Error: Library "ppx_demo" not found.
  • clipboard
File "examples/clipboard/dune", line 2, characters 42-54:
2 |  (libraries bonsai_web bonsai_web_ui_form js_clipboard)
                                              ^^^^^^^^^^^^
Error: Library "js_clipboard" not found.
  • codemirror
File "examples/codemirror/dune", line 3, characters 21-38:
3 |   ppx_css.inline_css codemirror_themes)
                         ^^^^^^^^^^^^^^^^^
Error: Library "codemirror_themes" not found.
  • codicons
File "examples/codicons/dune", line 3, characters 2-14:
3 |   js_clipboard)
      ^^^^^^^^^^^^
Error: Library "js_clipboard" not found.
  • dagviz
File "examples/dagviz/dune", line 5, characters 57-65:
5 |   (pps js_of_ocaml-ppx ppx_typed_fields ppx_jane ppx_css ppx_demo ppx_bonsai)))
                                                             ^^^^^^^^
Error: Library "ppx_demo" not found.
  • drilldown
File "examples/drilldown/dune", line 3, characters 2-27:
3 |   bonsai_web_ui_tree_layout)
      ^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Library "bonsai_web_ui_tree_layout" not found.
  • dygraph
File "bindings/dygraph/src/dune", line 7, characters 54-77:
7 |   virtual_dom.css_gen gen_js_api js_of_ocaml timezone piecewise_linear_kernel
                                                          ^^^^^^^^^^^^^^^^^^^^^^^
Error: Library "piecewise_linear_kernel" not found.
  • favicon_svg
File "examples/favicon_svg/dune", line 2, characters 50-61:
2 |  (libraries async_kernel async_js bonsai_web core favicon_svg
                                                      ^^^^^^^^^^^
Error: Library "favicon_svg" not found.
  • forms
File "examples/forms/dune", line 2, characters 23-52:
2 |  (libraries bonsai_web bonsai_web_ui_codemirror_form bonsai_web_ui_file
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Library "bonsai_web_ui_codemirror_form" not found.

(I'll add more as I find them, currently tested until gauge)

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Sep 20, 2023
@Enoumy
Copy link

Enoumy commented Oct 2, 2023

Heyo! Thanks for the bug reports!

I do have one question. Regarding the failures due to ppx_demo being missing, I think that ppx_demo has already been open sourced, but I don't think it's included within the bonsai opam package, so maybe you need to separately opam install ppx_demo?

Thanks!

@dysinger
Copy link

Even the hello_world example requires ppx_bonsai to build. ppx_bonsai looks like it's internal to this repo but the dune file is empty. Installing bonsai from a git pin gives you no such ppx to use. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

4 participants