Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource.dehydrate() doesn't respect Resource.exclude attribute #5

Open
mandx opened this issue Dec 27, 2012 · 1 comment
Open

Resource.dehydrate() doesn't respect Resource.exclude attribute #5

mandx opened this issue Dec 27, 2012 · 1 comment

Comments

@mandx
Copy link

mandx commented Dec 27, 2012

in line 139 of sliver/views.py:

        exclude = exclude or []

Should be something like:

        exclude = exclude or self.exclude
@jarcoal
Copy link
Owner

jarcoal commented Jan 4, 2013

Hi mandx, sorry about the delay. I looked into this and the get_context_data methods should seed the initial dehydrate method with it's excludes/fields. Haven't had time to test, so maybe something is still breaking.

I see that you made a fork. Send a pull request if you make some progress on this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants