Regalloc: improve printing of equiv. traces #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgregoir
reviewed
Jan 29, 2025
| @@ -0,0 +1,10 @@ | |||
| export fn main(reg u32 x) -> reg u32 { | |||
There was a problem hiding this comment.
I don't understand the interest of the test.
I mean we don't check that printing will not change, so what are we testing here ?
There was a problem hiding this comment.
You are right. This is just an example that I’ve been using to check these changes. However, there is no need to keep in in the repository. Let me remove it.
vbgl
force-pushed
the
regalloc-better-traces
branch
from
e2dadc0 to
122cd61
Compare
bgregoir
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026.