Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in Coq CI #1049

Closed
SkySkimmer opened this issue Feb 12, 2025 · 4 comments · Fixed by #1050
Closed

Broken in Coq CI #1049

SkySkimmer opened this issue Feb 12, 2025 · 4 comments · Fixed by #1050

Comments

@SkySkimmer
Copy link

eg https://gitlab.inria.fr/coq/coq/-/jobs/5319611 https://gitlab.inria.fr/coq/coq/-/jobs/5320146

Probably due to math-comp/hierarchy-builder#514 (cc @proux01) considering it's the difference between recent success https://gitlab.inria.fr/coq/coq/-/jobs/5319341 and the failures AFAICT

@proux01
Copy link
Contributor

proux01 commented Feb 12, 2025

Might be the case, jasmin is unfortunately one of the few missing thing in CI there (it's not in nixpkgs IIRC).
The good news is that it's probably just a missing requrie Strings or something in jasmin that was silently relying on HB exporting it, so should be fairly easy to fix for jasmin devs.

@proux01
Copy link
Contributor

proux01 commented Feb 12, 2025

The relevant part of the diff there seems to be

- From Coq Require Import String.
- Export String.StringSyntax.
- Global Open Scope string_scope.

(c.f. HB/structures.v in https://github.com/math-comp/hierarchy-builder/pull/514/files )

@vbgl
Copy link
Member

vbgl commented Feb 12, 2025

Thanks for reporting and investigating the issue.

@vbgl
Copy link
Member

vbgl commented Feb 12, 2025

Reproduced: https://gitlab.com/jasmin-lang/jasmin/-/jobs/9118451101#L8350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants