Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore test subdirectories #825

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Do not ignore test subdirectories #825

merged 3 commits into from
Jun 13, 2024

Conversation

eponier
Copy link
Contributor

@eponier eponier commented Jun 5, 2024

Make sure all the subdirectories are tested. Also renames some template files into *.jinc. Before the rename, they were tested in isolation while they do not make sense alone.

Fixes #823

@eponier
Copy link
Contributor Author

eponier commented Jun 5, 2024

The PR is a draft since the newly tested files are broken, so this PR depends on the fix of the tests.

@eponier
Copy link
Contributor Author

eponier commented Jun 6, 2024

New implementation on top of #820. ! was removed. We are now recursive by default (i.e. when we give a path, we test the files in all the subdirs of this path).

@eponier
Copy link
Contributor Author

eponier commented Jun 6, 2024

We now run jasminc on examples/gimli/x86-64/ecproof/gimli_ref{,1}.jazz, is this what we want?

eponier added 3 commits June 12, 2024 18:23
Otherwise they are tested alone.
Directories specified in tests.config are systematically traversed
recursively.
@eponier
Copy link
Contributor Author

eponier commented Jun 12, 2024

Undrafting, since #832 was merged.

@eponier eponier marked this pull request as ready for review June 12, 2024 16:41
@vbgl vbgl merged commit 94e8249 into main Jun 13, 2024
1 check passed
@vbgl vbgl deleted the test-subdirs branch June 13, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

large_stack is untested
2 participants