Add support for slices in array #copy #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
force-pushed
the
support-slices-in-copy
branch
from
c630622 to
c09aa13
Compare
vbgl
force-pushed
the
support-slices-in-copy
branch
from
c09aa13 to
e70e38e
Compare
bgregoir
reviewed
Aug 23, 2024
| @@ -0,0 +1,10 @@ | |||
| // Cannot copy by chunks of 4 bytes starting at offset 3 bytes | |||
There was a problem hiding this comment.
Why this should fail ? We can now have unaligned access.
There was a problem hiding this comment.
Currently, the copy operator only supports aligned accesses.
bgregoir
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842.