Add metadata to while conditions #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDaiki
force-pushed
the
while-expr-iloc
branch
from
ad2c697 to
15905aa
Compare
|
In addition to improving location information on guards of while loops and instructions emitted by lowering to implement them, this change allows to easily attach fixed points on while loops when doing analyses. |
eponier
reviewed
Dec 6, 2024
proofs/compiler/arm_lowering.v
Outdated
| let c0' := conc_map lower_i c0 in | ||
| let c1' := conc_map lower_i c1 in | ||
| [:: MkI ii (Cwhile a (c0' ++ map (MkI ii) pre) e' c1') ] | ||
| [:: MkI ii (Cwhile a (c0' ++ map (MkI ii) pre) e' info c1') ] |
There was a problem hiding this comment.
Suggested change
| [:: MkI ii (Cwhile a (c0' ++ map (MkI ii) pre) e' info c1') ] | |
| [:: MkI ii (Cwhile a (c0' ++ map (MkI info) pre) e' info c1') ] |
I think it should be info like was done for x86?
|
Thanks Jean-Christophe for your review. I’ve rephrased the changelog message and rebased on top of recent |
adding a new parameter to Prog.While to include an i_loc (useful for bug fixes)
vbgl
force-pushed
the
while-expr-iloc
branch
from
d557f0e to
6d4f6ae
Compare
eponier
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902.
Needs: