Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve TODO for conditional expressions in the SCT checker #909

Closed
sarranz opened this issue Sep 20, 2024 · 0 comments · Fixed by #913
Closed

Solve TODO for conditional expressions in the SCT checker #909

sarranz opened this issue Sep 20, 2024 · 0 comments · Fixed by #913
Assignees
@parjavadian
Labels
enhancement SCT checker

Comments

@sarranz
Copy link
Collaborator

sarranz commented Sep 20, 2024

Replace this TODO

jasmin/compiler/src/sct_checker_forward.ml

Line 732 in ac57159

(* TODO why is condition expression also added to constraints? *)
by a comment clarifying that this is the correct behavior and add a test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parjavadian parjavadian

Labels
enhancement SCT checker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve TODO for conditional expressions in the SCT checker jasmin-lang/jasmin
2 participants
@sarranz @parjavadian