Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve TODO for conditional expressions in the SCT checker #913

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Solve TODO for conditional expressions in the SCT checker #913

merged 1 commit into from
Sep 25, 2024

Conversation

parjavadian
Copy link
Contributor

fix #909

bgregoir
bgregoir reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a positive test ?

@bgregoir
Copy link
Contributor

Did you run dune promote in tests/sct-checker/ ?
I think it is why the check did not work.

@parjavadian
Solve TODO in the SCT-checker for conditional expressions
c8802cc 
Solve TODO for conditional expressions in the SCT checker
@vbgl vbgl merged commit a1786fa into main Sep 25, 2024
1 check passed
@vbgl vbgl deleted the todo-cond-expr branch September 25, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgregoir bgregoir bgregoir left review comments

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solve TODO for conditional expressions in the SCT checker
3 participants
@parjavadian @bgregoir @vbgl