-
|
Hello, I tried usign the backup script but the process halts when it tires to tar the backup files - from what it seems, there are no files populated into the /backups folder.
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 8 replies
-
|
Hi @TheNore - thanks for opening this issue! It is having trouble writing the tar file to BACKUP_FOLDER="/home/user/Powerwall-Dashboard/backups" # Destination folder for backups
DASHBOARD="/home/user/Powerwall-Dashboard" # Location of Dashboard to backupI notice that the backup.sh file has it as "/backup" by default which is probably why you did the same. I'm going to adjust it to help others. |
Beta Was this translation helpful? Give feedback.
-
|
I re-ran an upgrade and modified the file to reflect the correct parameters. It appears to be working now. Thanks as always @jasonacox |
Beta Was this translation helpful? Give feedback.
-
|
Awesome! My only TODO on this is that upgrade process will keep replacing this file and remove the localized (directory path) updates you make. Thoughts or suggestions? |
Beta Was this translation helpful? Give feedback.
-
|
Why not create a i.e. backup.conf to contain: # Set values for your environment
DASHBOARD="/home/user/Powerwall-Dashboard" # Location of Dashboard to backup
BACKUP_FOLDER="${DASHBOARD}/backups" # Destination folder for backups
KEEP="5" Then update the script to source the config defined environment variables. . backup.conf |
Beta Was this translation helpful? Give feedback.
-
|
I thought about that but two issues:
What if we just renamed it to Alternatively, the script could be adjust to require both variables interactively or be set on command line: backup.sh /home/user/Powerwall-Dashboard /home/user/Powerwall-Dashboard/backupsIf interactively, the first time you run it, it could ask for those variable and store them in a created backup.conf file for you (not overwritten by upgrade). The other logic for the "current directory" could be added - something like: MY_PATH=$(dirname "$0") # relative path
MY_PATH=$(cd "$MY_PATH" && pwd) # absolute path
if [[ -z "$MY_PATH/backup.conf" ]] ; then
echo "Setup: missing config file - Please set backup locations:"
# TODO
fi
source "$MY_PATH/backup.conf"
# rest of backup script... |
Beta Was this translation helpful? Give feedback.
-
I like this idea... in fact was just grappling with this problem for the Tesla history tool to make it as user friendly (and Git friendly) as possible. I ended up doing the same so it will interactively prompt the user for the config on first run and save that to a file - therefore the config file won't be tracked/affected by Git. Seems like a good solution. 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to not upgrade a specific file if the version for that file
doesn't change? So let's say backup.sh file version is 2.6.2 the next
update you make you didn't modify the backup.sh everything else would get
upgraded except that?
Or during the upgrade; unless you upgraded the backup.sh file, the upgrade
process stores the contents of the file then restores it on completing?
…On Wed, Oct 5, 2022, 10:46 PM Jason Cox ***@***.***> wrote:
Awesome! My only TODO on this is that upgrade process will keep replacing
this file and remove the localized (directory path) updates you make.
Thoughts or suggestions?
—
Reply to this email directly, view it on GitHub
<#95 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIDLQFR54G4KNTYJR2FKWQTWBZDQVANCNFSM6AAAAAAQ3RIQ3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
Hi @oralallen82 , good question. I have been thinking about updating the upgrade process. The current method just uses git to pull the files and forces overwrite merge, specifically: Unfortunately, that will always wipe out local files with files in the repo, but doesn't touch additional files which is why env files are safe. A better method is probably using the release archive (zip) or better yet, an upgrade bundle to install what was changed (to your point). I need to do more research to see what else is available. I'm sure others have solved this. If anyone has any time and expertise in this area, I would love a volunteer to help build a better upgrade system. 🙏 |
Beta Was this translation helpful? Give feedback.
Hi @TheNore - thanks for opening this issue!
It is having trouble writing the tar file to
/home/pi/Powerwall-Dashboard/backup/- There is a typo in theBACKUP_FOLDERvariable you are using. It should bebackupswith ans. You should be able to make the edits in the backup.sh file:I notice that the backup.sh file has it as "/backup" by default which is probably why you did the same. I'm going to adjust it to help others.