Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump fontawesome version (close javalent#445) #447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrCrackerplays
Copy link

Pull Request Description

Updates the fontawesome version used to the current latest (6.5.2) to increase the number of icons available for map markers.

Changes Proposed

  • Updates the fontawesome version used for marker icons to the current latest (6.5.2)

Related Issues

Fixes #445

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes. not applicable
  • My code follows the coding style and standards of this project. not applicable
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully. not applicable
  • I have run linters and fixed any issues. not applicable
  • I have checked for any potential security issues or vulnerabilities.

Additional Notes

From my testing some icons appear multiple times but they're the exact same and don't cause any issues.

@nicolatroehler
Copy link

Is there any ETA for this? Would love to have letters on my markers. Or was anyone able to compile their own version, I get critical errors when trying to compile my own version of the plugin.

@MrCrackerplays
Copy link
Author

I think development on the plugin has been on pause for almost a year now, so I wouldn't get you hopes up for an update any time soon.

As for building it yourself, try making sure your node version is up to date. I believe I had issues running npm run build originally but updating npm fixed those and allowed me to compile without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧩 Update font awesome dependency's version
2 participants