Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream PR #3

Open
aparcar opened this issue Jan 13, 2021 · 8 comments
Open

Upstream PR #3

aparcar opened this issue Jan 13, 2021 · 8 comments

Comments

@aparcar
Copy link
Contributor

aparcar commented Jan 13, 2021

Any plans to suggest these patches to upstream?

@jayanta525
Copy link
Owner

jayanta525 commented Jan 14, 2021

Hi @aparcar

I planned on sending the Linux patches upstream as well as to OpenWrt, but IMHO considering the available interfaces on this board, it would not make a great router, also taking in account all the available alternatives in the same budget category. Also there's has been no mention of this board in OpenWrt forums.

A 100M ethernet port is a huge bottleneck, pushing only 94Mbps.

RADXA (the vendor) is working on a new board (aka E3) with an integrated network switch with the same SoC. I got occupied with getting the E3 to work with OpenWrt, and will surely send the patches for the E3 upstream once done.

You are most welcome to send the patches for the ROCK Pi E upstream if you feel interested.

@aparcar
Copy link
Contributor Author

aparcar commented Jan 14, 2021

I'll do so, OpenWrt is not just for classical WiFi routers but also e.g. switches or gateways for other wireless protocols, like LoRa.

Could you please open a PR on OpenWrt and I'll help reviewing it? It'd look strange if I propose code created by someone else.

@jayanta525
Copy link
Owner

Sure, I will open a PR at openwrt after I send the Linux Kernel patches.

I would be glad if you could provide me with some tips/tricks on formatting patches to send to Linux maintainers, I don't want to make a bad first impression.

Thank you.

@aparcar
Copy link
Contributor Author

aparcar commented Jan 15, 2021

I can help with OpenWrt patches, for kernel patches exists an extensive document with a step by step guide: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

jayanta525 pushed a commit that referenced this issue Jan 17, 2021
The Ubiquiti Network airCube AC is a cube shaped device supporting
2.4 GHz and 5 GHz with internal 2x2 MIMO antennas.
It can be powered with either one of:
 - 24v power supply with 3.0mm x 1.0mm barrel plug
 - 24v passive PoE on first LAN port
There are four 10/100/1000 Mbps ports (1 * WAN + 3 * LAN).
First LAN port have optional PoE passthrough to the WAN port.

SoC:       Qualcomm / Atheros AR9342
RAM:       64 MB DDR2
Flash:     16 MB SPI NOR
Ethernet:  4x 10/100/1000 Mbps (1 WAN + 3 LAN)
LEDS:      1x via a SPI controller (not yet supported)
Buttons:   1x Reset
Serial:    1x (only RX and TX); 115200 baud, 8N1

Missing features:
 - LED control is not supported

Physical to internal switch port mapping:
 - physical port #1 (poe in) = switchport 2
 - physical port #2 = switchport 3
 - physical port #3 = switchport 5
 - physical port #4 (wan/poe out) = switchport 4

Factory update is tested and is the same as for Ubiquiti AirCube ISP
hence the shared configuration between that devices.

Signed-off-by: Roman Kuzmitskii <[email protected]>
@jayanta525
Copy link
Owner

Just found out this patch:
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/

Seems that ROCK Pi E is already sent for upstream.

I will update the DTS files for OpenWrt to match with that of upstream.

@thunderstorm99
Copy link

are there any news regarding upstreaming this to openwrt?

@jayanta525
Copy link
Owner

the upstream dts includes various other features that isn't available on 5.4 kernel. A lot of upstream backports is to be added if 5.4-target is to be compiled. 5.10 works great though.

@mlois-efimob
Copy link

Hi, any news to upstream this changes to OpenWrt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants