Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect() #5

Open
jayunit100 opened this issue Feb 19, 2020 · 0 comments
Open

Expect() #5

jayunit100 opened this issue Feb 19, 2020 · 0 comments

Comments

@jayunit100
Copy link
Owner

from slack: (shaun crampton, project calico)

I suggest having Expect() take a pair of interface arguments for the source and dest. In the felix FVs I quickly found that I wanted to expand on the types of source and dest that the connectivity checked could handle. The first time I did that, I added a new optional arg to ExpectSome/ExpectNone (for the destination port) but I regretted that decision as soon as the next variant came along.
In k8s, I expect we'll want destination types that include: pods, host-networked pods, nodeports, service IPs, external IPs(?), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant