Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target - strand features #104

Open
greenkidneybean opened this issue Feb 10, 2025 · 2 comments
Open

Target - strand features #104

greenkidneybean opened this issue Feb 10, 2025 · 2 comments

Comments

@greenkidneybean
Copy link

This is a long shot, but could the Target class include - strand features? My pacbio_amplicon.gb includes a single barcode and two genes in reverse orientations. My work-around is to run the pipeline twice with each gene on the + strand, then merge outputs on the barcodes.

file: alignparse/targets.py
lines: 162-166

            if bio_feature.location.strand != 1:
                raise ValueError(
                    f"feature {feature_name} of {self.name} is - "
                    "strand, but only + strand features handled"
                )
@jbloom
Copy link
Member

jbloom commented Feb 10, 2025

This functionality should be possible in principle, but in reality I doubt I will have time to figure out how to implement this in the near future...

So for now, running two ways like you are doing may be the best bet.

It would also be great if you decide you want to tackle a pull request to make the change.

Alternatively, I will keep this issue open and hopefully get to it eventually, but don't anticipate being able to do that in a short timeframe.

@greenkidneybean
Copy link
Author

Thanks Jesse! Feel free to close this issue, no need to turn it into a time suck. I'll follow-up with a pull request if I get something working. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants