From 1c6de78c824d6d8c0e593128c5d25aa34cd3d5de Mon Sep 17 00:00:00 2001 From: Joshua Chen Date: Wed, 7 Aug 2024 20:53:27 -0400 Subject: [PATCH] Other fixes for Mozilla docs --- config/allowed-code-link-text.txt | 12 ++++++++++++ docs/warning-info.md | 1 - src/server/create-graph.ts | 10 +++++----- src/server/process-warnings.ts | 9 +++++---- 4 files changed, 22 insertions(+), 10 deletions(-) diff --git a/config/allowed-code-link-text.txt b/config/allowed-code-link-text.txt index e093b83..b2bc3ac 100644 --- a/config/allowed-code-link-text.txt +++ b/config/allowed-code-link-text.txt @@ -43,6 +43,7 @@ steps(n, ) "x" in obj FileSystemHandle.requestPermission({mode: 'readwrite'}) Math.floor(x + 0.5) +MediaStream.addEventListener('addtrack', ...) Object.defineProperty(obj, prop, { get: func, configurable: true, enumerable: true }) Object.defineProperty(obj, prop, { set: func, configurable: true, enumerable: true }) Object.getOwnPropertyDescriptor(obj, prop)?.enumerable ?? false @@ -55,6 +56,7 @@ arr.slice(0, -1) canvas.getContext('2d', { alpha: false }) canvas.toDataURL('image/jpeg', quality) concat([v1, v2]) +contain-intrinsic-size: auto none cubic-bezier(0, 0, 1, 1) cubic-bezier(p1, p2, p3, p4) delete obj.x @@ -66,8 +68,15 @@ navigator.credentials.get({otp: ..., ...}) navigator.credentials.get({publicKey: ..., ...}) new Proxy(target, handler) slice(0, -1) +tabs.query({active: true}) +tabs.query({currentWindow: true}) + +JS_DoubleToInt32() +NPN_GetValue() +NPP_GetValue() Other stuff: + @@ -87,3 +96,6 @@ gl.getProgramParameter(program, gl.ACTIVE_UNIFORMS) non-standard_header non-standard_inline secureContext_header + +declarative_net_request.rule_resources +browser_specific_settings.gecko.id diff --git a/docs/warning-info.md b/docs/warning-info.md index 9ef6e9c..cfa5045 100644 --- a/docs/warning-info.md +++ b/docs/warning-info.md @@ -166,5 +166,4 @@ In an editor, you can do the following regex replacements: | `https?:\/\/(issues\.chromium\.org)\/issues\/(\d+)` | `https://crbug.com/$2` | | `https?:\/\/(bugs\.chromium\.org\|code\.google\.com)\/p\/chromium\/issues\/detail\?id=(\d+)` | `https://crbug.com/$2` | | `https?:\/\/(bugs\.chromium\.org\|code\.google\.com)\/p\/((?!chromium)\w+)\/issues\/detail\?id=(\d+)` | `https://crbug.com/$2/$3` | -| `https?:\/\/chromium\.googlesource\.com\/chromium\/src\/\+\/([\w\d]+)` | `https://crrev.com/$1` | | `https?:\/\/bugs\.webkit\.org\/show_bug\.cgi\?id=(\d+)` | `https://webkit.org/b/$1` | diff --git a/src/server/create-graph.ts b/src/server/create-graph.ts index e33d9ec..7507b40 100644 --- a/src/server/create-graph.ts +++ b/src/server/create-graph.ts @@ -11,7 +11,7 @@ const allowedCodeLinkTextRec = new Map( const allowedSpacedCodeLink = [ // HTML tags - /^<(a|area|font|iframe|input|link|meta|object|ol|script|th|tr)( [a-z-]+="[\w .…-]+"| ping| defer)+>$/, + /^<(a|area|font|iframe|input|link|meta|object|ol|script|th|tr)( [a-z-]+="[\w .…-]+"| ping| defer| sandbox| nomodule)+>$/, /^<\?xml[^>]+\?>$/, /^]+>$/, /^[a-z-]+="[\w .…-]+"$/, @@ -21,13 +21,13 @@ const allowedSpacedCodeLink = [ // want to check that methods in interface DLs don't have params /^[\w.]+\([\w.]+(, [\w.]+)*\)$/, // CSS code - /^([a-z-]+: ([a-z-]+|\d+(px|em|vh|vw|%)|0);?|@(container|import|media|namespace|supports) [()a-z: -]+|transform: [\w-]+\(\);?|transform-style: [\w-]+;?)$/, + /^([a-z-]+: ([a-z-]+|\d+(px|em|vh|vw|%)|0);?|@(container|import|media|namespace|supports) [()a-z\d: -]+|transform: [\w-]+\(\);?|transform-style: [\w-]+;?)$/, // Shell commands /^(ng|npm) [a-z\d]+$/, // HTTP status /^\d+ [\w '-]+$/, // HTTP header - /^(Cache-Control|Clear-Site-Data|Connection|Content-Length|Content-Security-Policy|Cross-Origin-Opener-Policy|Cross-Origin-Resource-Policy|Permissions-Policy|Sec-Purpose|Transfer-Encoding): ([\w-]+|"[\w-]+")$/, + /^(Cache-Control|Clear-Site-Data|Connection|Content-Length|Content-Security-Policy|Cross-Origin-Opener-Policy|Cross-Origin-Resource-Policy|Feature-Policy|Permissions-Policy|Sec-Purpose|Transfer-Encoding): ([\w-]+|"[\w-]+")$/, // MIME /^[a-z]+\/[\w+-]+; [a-z]+=("[\w ,.-]+"|\w+);?$/, // Macro calls @@ -50,7 +50,7 @@ const allowedUnderscoreCodeLink = [ // Link targets /^_(blank|parent|replace|self|top)$/, // File names - /\.(js|html)$/, + /\.(js|html|json)$/, // String constants /^"\w+"$/, // Macro calls @@ -166,7 +166,7 @@ graph.forEachNode((node) => { .contents() .filter((i, el) => el.type === "text"); for (const text of texts) { - if (/`.*`|\*.*\*|\[.*\]\(.*\)|\b_.*_\b/.test(text.data)) { + if (/`.+`|\*.+\*|\[.+\]\(.+\)|\b_.+_\b/.test(text.data)) { report(node, "Possibly unrendered Markdown", text.data); } } diff --git a/src/server/process-warnings.ts b/src/server/process-warnings.ts index 51eac5c..f5856d6 100644 --- a/src/server/process-warnings.ts +++ b/src/server/process-warnings.ts @@ -206,10 +206,11 @@ const bugLinkShorteners: [RegExp, string][] = [ /^https?:\/\/(bugs\.chromium\.org|code\.google\.com)\/p\/((?!chromium)\w+)\/issues\/detail\?id=(\d+)/g, "https://crbug.com/$2/$3", ], - [ - /^https?:\/\/chromium\.googlesource\.com\/chromium\/src\/\+\/([\w\d]+)/g, - "https://crrev.com/$1", - ], + // I don't think it works + // [ + // /^https?:\/\/chromium\.googlesource\.com\/chromium\/src\/\+\/([\w\d]+)/g, + // "https://crrev.com/$1", + // ], [ /^https?:\/\/bugs\.webkit\.org\/show_bug\.cgi\?id=(\d+)/g, "https://webkit.org/b/$1",