Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled data is not current #4

Open
OnkarRuikar opened this issue Sep 9, 2024 · 1 comment
Open

Compiled data is not current #4

OnkarRuikar opened this issue Sep 9, 2024 · 1 comment

Comments

@OnkarRuikar
Copy link
Contributor

The build and deployment are done every midnight because the https://jc-verse.github.io/mdn-graph/warnings is supposed to show the latest issues, right?
Doing builds from the content repo is not using the latest yari code. Yari doesn't release to npmjs.com that often, so the fixes done in Yari don't reflect in builds done from content. For example, a redirect fix done in Yari won't reflect on mdn-graph/warnings till Yari does the npm release.

In the daily build and deploy workflow, it would be better to check out mdn/yari, update the .env file to point to the content repo, and then build from Yari directory using the yarn build command. And also show yari commit in the top left info panel.

@Josh-Cena
Copy link
Member

Good idea, will check later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants