Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (ef28230) to head (f6d692f).

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   79.56%   79.54%   -0.02%     
==========================================
  Files          23       23              
  Lines        1962     1965       +3     
==========================================
+ Hits         1561     1563       +2     
- Misses        401      402       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi @Rapsssito, thanks for your contribution!

Small comments:

1. Did you test your code? It doesn't look like skip_animations is passed to Manim (which will thus render the animations, but skip them from Manim Slides's config). I think you need to edit the following
   

   manim-slides/manim_slides/slide/manim.py

   Lines 107 to 118 in 541b175

   	@BaseSlideConfig.wrapper("base_slide_config")
   	def next_slide(
   	self,
   	*args: Any,
   	base_slide_config: BaseSlideConfig,
   	**kwargs: Any,
   	) -> None:
   	Scene.next_section(self, *args, **kwargs)
   	BaseSlide.next_slide.__wrapped__(
   	self,
   	base_slide_config=base_slide_config,
   	)

   
   and set something like Scene.next_section(self, *args, skip_animations=base_slide_config.skip_animations, **kwargs) to make sure the argument is passed to next_section.
2. Could you add a test in tests/test_slides.py::TestSlide?
3. Could you document your changes in the CHANGELOG?

Many thanks!

@jeertmans, I did test the code, but I just checked if the slide was indeed not there... My bad. I am sorry about my ignorance, but how can I test it in tests/test_slides.py::TestSlide? Is there a way to check for the existence intermediate animation files?

We don't need to go that far in the testing, especially as it would highly depend on where Manim stores partial animation files.

But you could add a test that reads the PresentationConfig object (from the generated .json file) and checks that slides are indeed missing when skip_animations=True is set.

Note, it might be interesting to document this new parameter here:

and mention that it is passed to `:meth:`Scene.next_section<manim.scene.scene.Scene.next_section>`, or ignored if `manimlib` API is used.