Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculated percentages can be wrong #9

Open
SPPearce opened this issue May 31, 2020 · 0 comments
Open

Calculated percentages can be wrong #9

SPPearce opened this issue May 31, 2020 · 0 comments

Comments

@SPPearce
Copy link

SPPearce commented May 31, 2020

When the levels in the group factor don't appear in the sample table in the same order, then the calculated percentages are wrong.

This can be fixed by replacing line 393 in analysis.R:

meth.per <- t(t(meth.freq)/as.vector(table(samp$group)))

with:

meth.per <- t(t(meth.freq)/as.vector(table(samp$group)[colnames(meth.freq)]))

I don't know if there is anywhere else with the same issue.
I've created a pull request for this point #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant