show validation error if time input is partially filled #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work in Firefox. Seems like Firefox is not considering a partially filled time input as invalid. Other browsers are not affected. UI used by Edge prevents partially filling a time input. Desktop Safari and IE11 do not support |
jelhan
deleted the
issue-277-partially-filled-input-time-should-issue-a-validation-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a validation error for time input if the input is partially filled (e.g.
10:--).I fear this can not be tested cause I'm not aware of any method to fill a time input partially using JavaScript.
Closes #277