Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Grid in UserSelectView gets cut off with more than one user #1425

Open
samglt opened this issue Feb 8, 2025 · 0 comments
Open

[iOS] Grid in UserSelectView gets cut off with more than one user #1425

samglt opened this issue Feb 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@samglt
Copy link
Contributor

samglt commented Feb 8, 2025

The grid of user icons in the UserSelectView gets cut off and doesn't scroll when more than two icons are shown. This looks like it was introduced in #1328.

I think the issue is that something in the UserGridButton is using trackingSize() while the VGrid's .scrollIfLargerThanContainer() also uses trackingSize() to determine its frame size. Maybe the GeometryPreferenceKey gets set to multiple values within the same tree at the same time and breaks the scrollIfLargerContainer.

I can't untangle exactly which change would have caused this to happen though since the previous commit also has uses of trackingSize inside the UserGridButton.

Image

@JPKribs JPKribs added the bug Something isn't working label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants