Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu fails when user doesn't have delete permission #295

Open
TrueTechy opened this issue Jul 30, 2023 · 0 comments
Open

Context menu fails when user doesn't have delete permission #295

TrueTechy opened this issue Jul 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@TrueTechy
Copy link
Contributor

Describe the bug
If a user's delete permission on the server is removed between them opening the context menu, and clicking on the delete option, it results in an error, and the context menu stops using the jellycon one and goes back to the Kodi one

To Reproduce

  1. Select item
  2. Open context menu
  3. On Server - Remove users delete permission for the library
  4. On Client - Click delete

Expected behavior
The error message shows

Logs

2023-07-30 20:30:44.722 T:77633   ERROR <general>: Traceback (most recent call last):
2023-07-30 20:30:44.722 T:77633   ERROR <general>:   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner    
2023-07-30 20:30:44.722 T:77633   ERROR <general>: self.run()
2023-07-30 20:30:44.722 T:77633   ERROR <general>:   File "/home/abby/.kodi/addons/plugin.video.jellycon/resources/lib/monitors.py", line 41, in run
2023-07-30 20:30:44.733 T:77633   ERROR <general>: show_menu(params)
2023-07-30 20:30:44.733 T:77633   ERROR <general>:   File "/home/abby/.kodi/addons/plugin.video.jellycon/resources/lib/functions.py", line 575, in show_menu
2023-07-30 20:30:44.733 T:77633   ERROR <general>: delete(item_id)
2023-07-30 20:30:44.733 T:77633   ERROR <general>:   File "/home/abby/.kodi/addons/plugin.video.jellycon/resources/lib/functions.py", line 274, in delete
2023-07-30 20:30:44.734 T:77633   ERROR <general>: xbmcgui.Dialog().ok(
2023-07-30 20:30:44.734 T:77633   ERROR <general>: TypeError
2023-07-30 20:30:44.734 T:77633   ERROR <general>: function takes at most 2 arguments (3 given)

System (please complete the following information):

  • OS: Ubuntu
  • Jellyfin Version: 10.8.10
  • Kodi Version: 19.4
  • Addon Version: 0.7
@TrueTechy TrueTechy added the bug Something isn't working label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant