-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No sound when playing transcoded Video with FLAC audio stream #907
Comments
Same here. I've enabled forced transcoding and chose the aac / ac3 for audio codec but I see ffmpeg command still uses flac.
|
Gah, this issue has been my single personal annoyance with Jellyfin for years now. I was under the impression that it's a Jellyfin server issue, but the people over at Jellyfin server have recently stated that this should not be an issue on their end (which is supported by the fact that other clients do not have this issue), so I guess the problem is with the Jellyfin Kodi plugin after all. Skimming through the code for a whole of 5 minutes I stumbled on this (in
...followed by this:
Now, if I'm getting this right (and I could very well be way off, seeing as I've pretty much only read this part of the code) it seems like the plugin advertises the audio formats it supports for transcoding into as the above So perhaps if FLAC were to be removed from this array, the issue could be fixed? |
jellyfin-kodi/jellyfin_kodi/helper/playutils.py Lines 406 to 413 in 6140ea8
Removing flac from that list would likely cause it to get transcoded into aac (by default – audioPreferredCodec setting) Video codecs have a few settings to force transcoding of mp2, hevc, av1 and vc1 jellyfin-kodi/jellyfin_kodi/helper/playutils.py Lines 385 to 404 in 6140ea8
|
Yeah, so it works more or less as I Imagined. If everything stays at the default state, then during transcoding the audio will get transcoded to the widely compatible AAC by default (with a list of further possible candidates), just like video will get transcoded to the widely compatible H.264 by default (with, again, a list of further candidates). For the video part, the user can opt to select something else in the settings as the preferred video codec to transcode into, and the same functionality could (and should) be added to the audio part, because it's very useful (for example, some specific audio format could be supported for pass-through on some specific sound device, although that's often enough the case with the default AAC). But aside from all that, this specific issue arises from the fact that FLAC is also included in that list of possible format candidates, so when the system tries to transcode a media file which contains FLAC audio, the audio part is considered as already compatible and so is left untouched, and is then (attempted to be) muxed into the TS container with the transcoded video stream, but the TS container doesn't support FLAC audio, which leads to the issue. So yes, I think the proper solution here should be to remove FLAC from the possible transcode candidates and so let FLAC audio streams be transcoded to AAC as they should. |
It seems to be related to jellyfin/jellyfin#8224 (comment).
Playing any video file - transcoded - will result in no audio when the FLAC track is selected.
This is not an issue when direct-playing the video file. All audio codecs work fine then.
Also all other clients tested by me:
Work without the audio dropping.
The text was updated successfully, but these errors were encountered: