Thumbnails disappear after hiding and re-enabling OSC

[sheharyarn]

Describe the bug

I like to keep the OSC hidden until I need to use it. I use a custom keymap to hide/show it:

# input.conf
O  cycle osc  # cycle osc visibility

When the video first starts playing, it correctly shows the trickplay/thumbs on hover. But if then I hide the OSC and show it again, they no longer appear.

I'm not sure if this is a bug or if the OSC I have configured in my mpv.conf is different from what jellyfin-mpv-shim uses underneath.

To Reproduce

1. Start jellyfin-mpv-shim
2. Connect to the shim from jellyfin
3. Play a video
4. Hover over OSC to show thumbs
5. Hide the OSC
6. Re-enable the OSC
7. Hover over the OSC to see thumbs no longer appear

Expected behavior

Thumbs continue to appear when OSC is re-enabled

Screenshots + Video

Before	After

jellyfin-shim-osc.mp4

Versions

• OS: MacOS - Sonoma 14.5 (23F79)
• Jellyfin: 10.9.8
• MPV: 0.37.0 (Using ffmpeg 5.1.4)
• Shim: 2.8.0

Configs

• MPV:
  • mpv.conf
  • input.conf
• Shim:
  • conf.json

Logs

▲ code jellyfin-mpv-shim                                                                                     

2024-08-18 15:21:01,297 [ WARNING] player: Could not find libmpv1.
2024-08-18 15:21:01,298 [    INFO] player: Using external mpv playback backend.
2024-08-18 15:21:01,524 [ WARNING] mpv: trickplay_osc: lua-settings/ is deprecated, use directory script-opts/
2024-08-18 15:21:01,529 [    INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: Begin connect
2024-08-18 15:21:01,529 [    INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: Begin getAvailableServers
2024-08-18 15:21:01,529 [    INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: connect has 1 servers
2024-08-18 15:21:01,530 [    INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: begin connect_to_server
2024-08-18 15:21:01,530 [    INFO] JELLYFIN.jellyfin_apiclient_python.api: Sending get request to system/info/public
2024-08-18 15:21:02,401 [    INFO] JELLYFIN.jellyfin_apiclient_python.connection_manager: calling onSuccessfulConnection with server jellyfin.psy.sh
2024-08-18 15:21:02,401 [    INFO] JELLYFIN.jellyfin_apiclient_python.api: Sending get request to system/info
2024-08-18 15:21:03,269 [    INFO] JELLYFIN.jellyfin_apiclient_python.client: User is authenticated.
2024-08-18 15:21:03,269 [    INFO] JELLYFIN.jellyfin_apiclient_python.ws_client: Websocket url: wss://jellyfin.psy.sh/socket?api_key=REDACTED&device_id=cc53e05b-ebc8-4b1e-8ff4-8d76355bfcda
2024-08-18 15:21:04,136 [    INFO] websocket: Websocket connected
2024-08-18 15:21:04,138 [    INFO] JELLYFIN.jellyfin_apiclient_python.ws_client: --->[ websocket ]
404 Client Error: Not Found for url: https://jellyfin.psy.sh/Episode/5a7751570ca659807802f5aa5cbdf8ae/IntroSkipperSegments
2024-08-18 15:21:17,792 [   ERROR] Jellyfin.jellyfin_apiclient_python.http: 404 Client Error: Not Found for url: https://jellyfin.psy.sh/Episode/5a7751570ca659807802f5aa5cbdf8ae/IntroSkipperSegments
2024-08-18 15:21:17,792 [ WARNING] media: Fetching intro data failed. Do you have the plugin installed?
Traceback (most recent call last):
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/jellyfin_apiclient_python/http.py", line 119, in request
    r.raise_for_status()
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://jellyfin.psy.sh/Episode/5a7751570ca659807802f5aa5cbdf8ae/IntroSkipperSegments

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/jellyfin_mpv_shim/media.py", line 251, in get_intro
    skip_intro_data = self.client.jellyfin._get(
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/jellyfin_apiclient_python/api.py", line 63, in _get
    return self._http("GET", handler, {'params': params})
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/jellyfin_apiclient_python/api.py", line 50, in _http
    return self.client.request(request)
  File "/Users/Psy/.asdf/installs/python/3.8.10/lib/python3.8/site-packages/jellyfin_apiclient_python/http.py", line 174, in request
    raise HTTPException(r.status_code, error)
jellyfin_apiclient_python.exceptions.HTTPException: (404, HTTPError('404 Client Error: Not Found for url: https://jellyfin.psy.sh/Episode/5a7751570ca659807802f5aa5cbdf8ae/IntroSkipperSegments'))
2024-08-18 15:21:17,796 [    INFO] mpv: thumbfast: Clearing trickplay.
2024-08-18 15:21:29,012 [    INFO] mpv: cplayer: (+) Video --vid=1 (*) 'Presented By EMBER' (hevc 1920x1080 23.976fps)
2024-08-18 15:21:29,013 [    INFO] mpv: cplayer: Video --vid=2 [P] 'cover.jpg' (mjpeg)
2024-08-18 15:21:29,013 [    INFO] mpv: cplayer: Audio --aid=1 --alang=eng (*) 'Golumpa@FUNI' (aac 2ch 48000Hz)
2024-08-18 15:21:29,014 [    INFO] mpv: cplayer: (+) Audio --aid=2 --alang=jpn (ac3 2ch 48000Hz)
2024-08-18 15:21:29,014 [    INFO] mpv: cplayer: (+) Subs  --sid=1 --slang=eng (*) 'Signs & Songs@EMBER' (ass)
2024-08-18 15:21:29,014 [    INFO] mpv: cplayer: Subs  --sid=2 --slang=eng 'Dialogue@EMBER' (ass)
2024-08-18 15:21:29,014 [    INFO] mpv: display-tags: File tags:
2024-08-18 15:21:29,014 [    INFO] mpv: display-tags: Title: S02E08-EMBER
2024-08-18 15:21:29,311 [    INFO] mpv: cplayer: AO: [coreaudio] 48000Hz stereo 2ch floatp
2024-08-18 15:21:29,312 [    INFO] mpv: cplayer: Track switched:
2024-08-18 15:21:29,312 [    INFO] mpv: cplayer: (+) Video --vid=1 (*) 'Presented By EMBER' (hevc 1920x1080 23.976fps)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Video --vid=2 [P] 'cover.jpg' (mjpeg)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: (+) Audio --aid=1 --alang=eng (*) 'Golumpa@FUNI' (aac 2ch 48000Hz)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Audio --aid=2 --alang=jpn (ac3 2ch 48000Hz)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: (+) Subs  --sid=1 --slang=eng (*) 'Signs & Songs@EMBER' (ass)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Subs  --sid=2 --slang=eng 'Dialogue@EMBER' (ass)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Track switched:
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: (+) Video --vid=1 (*) 'Presented By EMBER' (hevc 1920x1080 23.976fps)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Video --vid=2 [P] 'cover.jpg' (mjpeg)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: (+) Audio --aid=1 --alang=eng (*) 'Golumpa@FUNI' (aac 2ch 48000Hz)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Audio --aid=2 --alang=jpn (ac3 2ch 48000Hz)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: (+) Subs  --sid=1 --slang=eng (*) 'Signs & Songs@EMBER' (ass)
2024-08-18 15:21:29,313 [    INFO] mpv: cplayer: Subs  --sid=2 --slang=eng 'Dialogue@EMBER' (ass)
2024-08-18 15:21:31,668 [    INFO] mpv: cplayer: VO: [libmpv] 1920x1080 yuv420p10
2024-08-18 15:21:31,805 [    INFO] update_check: Checking for updates...
2024-08-18 15:21:31,818 [    INFO] trickplay: Collecting trickplay images...
2024-08-18 15:21:34,491 [ WARNING] mpv: cplayer: Audio device underrun detected.
2024-08-18 15:21:34,633 [    INFO] trickplay: Collected 144 trickplay preview images
2024-08-18 15:21:34,633 [    INFO] mpv: thumbfast: Received BIF data.
2024-08-18 15:26:01,336 [    INFO] clients: Performing client health check...
2024-08-18 15:28:10,950 [ WARNING] mpv: input: No key binding found for key 'Meta+SPACE'.
2024-08-18 15:28:38,999 [ WARNING] mpv: cplayer:
2024-08-18 15:28:39,004 [ WARNING] mpv: cplayer: Audio/Video desynchronisation detected! Possible reasons include too slow
2024-08-18 15:28:39,004 [ WARNING] mpv: cplayer: hardware, temporary CPU spikes, broken drivers, and broken files. Audio
2024-08-18 15:28:39,004 [ WARNING] mpv: cplayer: position will not match to the video (see A-V status field).
2024-08-18 15:28:39,004 [ WARNING] mpv: cplayer: Consider trying `--profile=fast` and/or `--hwdec=auto-safe` as they may help.
2024-08-18 15:28:39,004 [ WARNING] mpv: cplayer:
2024-08-18 15:28:47,186 [ WARNING] mpv: osc: lua-settings/ is deprecated, use directory script-opts/
2024-08-18 15:28:48,712 [   ERROR] mpv: ffmpeg: tls: IO error: Connection reset by peer
2024-08-18 15:28:48,712 [ WARNING] mpv: ffmpeg: https: Will reconnect at 56107492 in 0 second(s), error=Connection reset by peer.
2024-08-18 15:28:53,065 [ WARNING] mpv: osc: lua-settings/ is deprecated, use directory script-opts/
2024-08-18 15:31:01,900 [    INFO] clients: Performing client health check...