Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PersonKind #40

Open
JPKribs opened this issue Nov 5, 2024 · 0 comments
Open

Add PersonKind #40

JPKribs opened this issue Nov 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JPKribs
Copy link
Member

JPKribs commented Nov 5, 2024

New to the SDK side of this so let me know if this isn't the right place!

I'm completely clueless when it comes to SDK generation and patch files but it would be nice to have PersonKinds / PersonType in the SDK. I think this would be helpful for the Cast & Crew sections for clients.

Here is what I made for use in Swiftfin:

enum PersonKind: String, CaseIterable {
    case unknown = ""
    case actor = "Actor"
    case director = "Director"
    case composer = "Composer"
    case writer = "Writer"
    case guestStar = "GuestStar"
    case producer = "Producer"
    case conductor = "Conductor"
    case lyricist = "Lyricist"
    case arranger = "Arranger"
    case engineer = "Engineer"
    case mixer = "Mixer"
    case remixer = "Remixer"
    case creator = "Creator"
    case artist = "Artist"
    case albumArtist = "AlbumArtist"
    case author = "Author"
    case illustrator = "Illustrator"
    case penciller = "Penciller"
    case inker = "Inker"
    case colorist = "Colorist"
    case letterer = "Letterer"
    case coverArtist = "CoverArtist"
    case editor = "Editor"
    case translator = "Translator"
}

My source for this can be found here: https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Data/Enums/PersonKind.cs.

@JPKribs JPKribs added the enhancement New feature or request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant