Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular control over lifecycle hooks #7

Open
jesjos opened this issue Feb 21, 2016 · 7 comments
Open

Granular control over lifecycle hooks #7

jesjos opened this issue Feb 21, 2016 · 7 comments

Comments

@jesjos
Copy link
Owner

jesjos commented Feb 21, 2016

Right now we trigger save, create and commit hooks. The create hooks might be ill-advised, since we don't know if there is an extant record.

@benedikt
Copy link
Contributor

With #75 in place, it's possible to implement this properly. However it'd be a breaking change. I'm happy to implement it, but I'd like to hear your opinion on how to handle the breaking change.

Also, I think I figured out a way to return the attributes before the upsert if a record existed already. This would be useful to figure out changes to attributes after updates.

@olleolleolle
Copy link
Collaborator

For my money, a major version update's fine - make the break and move on - we're a small and active community of users, here.

@olleolleolle
Copy link
Collaborator

@benedikt Do you think we ought to release today? Is it a minor, so that we're at 0.10.0?

@benedikt
Copy link
Contributor

@olleolleolle Totally up to you. It’ll most likely take me a few days until I get to work on the callbacks.

@olleolleolle
Copy link
Collaborator

@benedikt Just a check - we're still not yet in "backwards-compat break", are we?

@benedikt
Copy link
Contributor

The recent changes only fixed two issues, no backwards incompatible changes, yet.

@olleolleolle
Copy link
Collaborator

@benedikt I released v0.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants