-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular control over lifecycle hooks #7
Comments
With #75 in place, it's possible to implement this properly. However it'd be a breaking change. I'm happy to implement it, but I'd like to hear your opinion on how to handle the breaking change. Also, I think I figured out a way to return the attributes before the upsert if a record existed already. This would be useful to figure out changes to attributes after updates. |
For my money, a major version update's fine - make the break and move on - we're a small and active community of users, here. |
@benedikt Do you think we ought to release today? Is it a minor, so that we're at |
@olleolleolle Totally up to you. It’ll most likely take me a few days until I get to work on the callbacks. |
@benedikt Just a check - we're still not yet in "backwards-compat break", are we? |
The recent changes only fixed two issues, no backwards incompatible changes, yet. |
@benedikt I released v0.9.2. |
Right now we trigger save, create and commit hooks. The create hooks might be ill-advised, since we don't know if there is an extant record.
The text was updated successfully, but these errors were encountered: