Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab MR link broken if there are carriage returns #3999

Closed
ginolegigot opened this issue Oct 18, 2024 · 2 comments
Closed

Gitlab MR link broken if there are carriage returns #3999

ginolegigot opened this issue Oct 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ginolegigot
Copy link

Hello!

Describe the bug
When a MR link is cut in several pieces because there are Carrriage Returns, the MR link appears clickable only on the first part

To Reproduce
Steps to reproduce the behavior:

Open lazygit in a small window, Push in a new branch, the MR link will be suggested. If the window is small enough the MR Link will be separated into several parts through line return. only the first part of the MR link will e clickable leading to a broken link in the browser

Expected behavior
The whole MR link remains clickable even if they are carriage returns.

Screenshots
test
In the screenshot only the part with https://gitlab is clickable the rest of the link is not.

Version info:
commit=611fabde11d24d9acc71ee26077b9a1101f59f27, build date=2024-09-18T10:56:10Z, build source=binaryRelease, version=0.44.1, os=linux, arch=amd64, git version=2.43.0

@ginolegigot ginolegigot added the bug Something isn't working label Oct 18, 2024
@stefanhaller
Copy link
Collaborator

This should already be fixed in master, see #3914. If you can build from master, could you please verify this?

@ginolegigot
Copy link
Author

Works like a charm thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants