Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttslock.sh not passing on shellcheck #538

Open
edumco opened this issue May 15, 2020 · 0 comments
Open

buttslock.sh not passing on shellcheck #538

edumco opened this issue May 15, 2020 · 0 comments

Comments

@edumco
Copy link

edumco commented May 15, 2020

While running make shellcheck the file buttslock.sh present error

eduardo@note:~/git/dockerfiles$ make shellcheck 
docker run --rm -i -t \
	--name df-shellcheck \
	-v /home/eduardo/git/dockerfiles:/usr/src:ro \
	--workdir /usr/src \
	r.j3ss.co/shellcheck ./shellcheck.sh
[OK]: sucessfully linted ./bashrc
[OK]: sucessfully linted ./bcc-tools/entrypoint.sh
[OK]: sucessfully linted ./build-all.sh

In ./buttslock/buttslock.sh line 19:
    -level 0%,100%,0.6 -blur $BLURTYPE $FONT \
                                       ^---^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
    -level 0%,100%,0.6 -blur $BLURTYPE "$FONT" \

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
[OK]: sucessfully linted ./distcc/distccd-init
[OK]: sucessfully linted ./firefox/entrypoint.sh
[OK]: sucessfully linted ./github-dev/cleanup-pr-branch
[OK]: sucessfully linted ./github-dev/release-email-notification
[OK]: sucessfully linted ./github-dev/upload-assets
[OK]: sucessfully linted ./gitiles/start.sh
[OK]: sucessfully linted ./gitserver/create_repo
[OK]: sucessfully linted ./gitserver/start.sh
[OK]: sucessfully linted ./kernel-builder/build_kernel
[OK]: sucessfully linted ./kvm/start.sh
[OK]: sucessfully linted ./latest-versions.sh
[OK]: sucessfully linted ./lkp-tests/runbench
[OK]: sucessfully linted ./mailgun/sendemail
[OK]: sucessfully linted ./metasploit/start.sh
[OK]: sucessfully linted ./mitmproxy/docker-entrypoint.sh
[OK]: sucessfully linted ./mpd/mpd.sh
[OK]: sucessfully linted ./mutt/entrypoint.sh
[OK]: sucessfully linted ./postfix/runit_bootstrap
[OK]: sucessfully linted ./postfix/service/postfix/run
[OK]: sucessfully linted ./postfix/service/rsyslog/run
[OK]: sucessfully linted ./radarr/entrypoint.sh
[OK]: sucessfully linted ./run.sh
[OK]: sucessfully linted ./runc-rootless/start.sh
[OK]: sucessfully linted ./shellcheck.sh
[OK]: sucessfully linted ./skype/run-skype-and-wait-for-exit
[OK]: sucessfully linted ./slapd/start.sh
[OK]: sucessfully linted ./sonarr/entrypoint.sh
[OK]: sucessfully linted ./sublime-text-3/run.sh
[OK]: sucessfully linted ./test.sh
[OK]: sucessfully linted ./tor-relay/run.sh
[OK]: sucessfully linted ./unifi/entrypoint.sh
[OK]: sucessfully linted ./vscode/start.sh
[OK]: sucessfully linted ./wireguard/install/entrypoint.sh
[OK]: sucessfully linted ./ykman/entrypoint.sh
[OK]: sucessfully linted ./ykpersonalize/entrypoint.sh
[OK]: sucessfully linted ./yubico-piv-tool/entrypoint.sh
These files failed shellcheck: ./buttslock/buttslock.sh
make: *** [Makefile:45: shellcheck] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant