[Bug]: babel-jest doesn't hoist references to jest correctly with @jest/globals

[anilanar]

Version

jest: 29.7.0

babel-preset-jest: 29.6.3

Steps to reproduce

These are some examples where hoisting works wrong:

import {jest} from '@jest/globals';


jest.mock('some-module', () => {
  const x = jest.requireActual('some-module');
  return x;
});

// ⬇️⬇️⬇️

_getJestObj().mock('some-module', () => {
  const x = jest.requireActual('some-module'); // should've been _getJestObj().requireActual
  return x;
});
function _getJestObj() {
  const {
    jest
  } = require("@jest/globals");
  _getJestObj = () => jest;
  return jest;
}
import { jest } from '@jest/globals';

import {jest} from '@jest/globals';


jest.mock('some-module', () => {
  const x = jest.requireActual('some-module');
  return x;
});

// ⬇️⬇️⬇️

_getJestObj().mock('some-module', () => {
  const x = jest.fn();  // should've been _getJestObj().fn
  return {
    x
  };
});
function _getJestObj() {
  const {
    jest
  } = require("@jest/globals");
  _getJestObj = () => jest;
  return jest;
}
import { jest } from '@jest/globals';

import {jest} from '@jest/globals';

jest.mock('some-module', () => ({
  x: jest.fn()
}));

// ⬇️⬇️⬇️

_getJestObj().mock('some-module', () => ({
  x: jest.fn() // should've been _getJestObj().fn
}));
function _getJestObj() {
  const {
    jest
  } = require("@jest/globals");
  _getJestObj = () => jest;
  return jest;
}
import { jest } from '@jest/globals';

Expected behavior

Expected correct hoisting.

Actual behavior

Wrong hoisting.

Additional context

No response

Environment

System:
    OS: macOS 15.2
    CPU: (11) arm64 Apple M3 Pro
  Binaries:
    Node: 20.11.0 - /nix/store/yxjxfg053nbr6rqzcicifsvzab8aa072-nodejs-20.11.0/bin/node
    Yarn: 4.6.0 - /nix/store/7i5rhk1svf3b0hz6j5xf1rmy75s1l2l6-yarn-1.22.21/bin/yarn
    npm: 10.2.4 - /nix/store/yxjxfg053nbr6rqzcicifsvzab8aa072-nodejs-20.11.0/bin/npm
  npmPackages:
    jest: 29.7.0 => 29.7.0

[anilanar]

Is there a reason for not hoisting top-level @jest/globals imports (if they exist) to the top of the file instead of the current solution?

[anilanar]

Our workaround:

1. Opt out of babel-preset-jest:
   a. Upgrade babel-jest to v30-alpha
   b. Pass excludeJestPreset: true option. (It'd be great to backport this to v29!)
2. Implement a babel plugin that hoists all top-level @jest/globals imports/requires to the top of the file (see below).
3. Modify babel.config
   a. add 'babel-plugin-jest-hoist' to plugins.
   b. add newly developed plugin to plugins.

Here's the custom plugin code:

module.exports = function (babel) {
  const { types: t } = babel;

  return {
    name: 'hoist-jest-globals',
    post({ path }) {
      const jestGlobals = [];

      path.get('body').forEach(nodePath => {
        if (nodePath.isImportDeclaration() && nodePath.node.source.value === '@jest/globals') {
          jestGlobals.push(nodePath.node);
          nodePath.remove();
        } else if (nodePath.isVariableDeclaration()) {
          const declarations = nodePath.get('declarations');
          declarations.forEach(decl => {
            const init = decl.get('init');
            if (
              init.isCallExpression() &&
              init.get('callee').isIdentifier({ name: 'require' }) &&
              init.get('arguments').length === 1 &&
              init.get('arguments.0').isStringLiteral({ value: '@jest/globals' })
            ) {
              jestGlobals.push(nodePath.node);
              nodePath.remove();
            }
          });
        }
      });

      if (jestGlobals.length > 0) {
        path.unshiftContainer('body', jestGlobals);
      }
    },
  };
};