Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetKVM always connects to api.jetkvm.com when settings are opened #107

Open
jjeising opened this issue Jan 28, 2025 · 1 comment
Open

JetKVM always connects to api.jetkvm.com when settings are opened #107

jjeising opened this issue Jan 28, 2025 · 1 comment
Labels
bug Something isn't working cloud good first issue Good for newcomers ui

Comments

@jjeising
Copy link

jjeising commented Jan 28, 2025

Every time the settings panel is shown, getUpdateStatus is called:

send("getUpdateStatus", {}, resp => {

GetUpdateStatus then calls fetchUpdateMetadata, which connects to api.jetkvm.com/releases:

https://github.com/jetkvm/kvm/blob/8ffe66a1bc63b38c3eea44ec3f10c75ba00836c1/ota.go#L449C25-L449C44

When auto update is disabled, JetKVM should only connect to api.jetkvm.com when "Check for updates" is run (probably in UpdateDialog).

@Nevexo
Copy link
Contributor

Nevexo commented Jan 28, 2025

It's not quite every time, as the settings menu items are only loaded when the page loads, but I agree that it shouldn't be trying to contact the API at all unless auto update is enabled/Check for Update is clicked.

@Nevexo Nevexo added bug Something isn't working good first issue Good for newcomers ui cloud labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cloud good first issue Good for newcomers ui
Projects
None yet
Development

No branches or pull requests

2 participants