Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding repository filter #260

Closed
wants to merge 1 commit into from
Closed

Adding repository filter #260

wants to merge 1 commit into from

Conversation

Hanstad
Copy link

@Hanstad Hanstad commented Jan 10, 2019

Adding repository filter to control which repositories this plugin affects.

Adding repository filter to control which repositories this plugin affects.
@DarthFennec
Copy link
Contributor

Hi, thanks for contributing! My apologies that it took so long to respond to this.

First, I noticed that your file has DOS (CRLF) line endings, and the original file has Unix (LF) line endings. This makes the diff ('Files Changed' tab) hard to read, since it thinks there are no lines in common. Since all the plugins here use Unix line endings, it's best to stick to that.

As for the code, it looks pretty good to me. My one concern is that if the properties file doesn't exist, it throws an exception. I think for backwards compatibility, it would be better if it selected all repositories if no file exists, same as it does with an empty repository list.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yashprit-jfrog
Copy link
Collaborator

Closing PR because its been inactive since a long time & contribution is on deprecated plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants