From b9172b57c3154c162336e8cbc42138414cbf8f86 Mon Sep 17 00:00:00 2001 From: Gerald Versluis Date: Fri, 26 Apr 2024 11:37:26 +0200 Subject: [PATCH] Apply suggestions from code review --- .../AudioRecorder/IAudioRecorder.shared.cs | 1 - src/Plugin.Maui.Audio/AudioRecordingOptions.cs | 6 ------ 2 files changed, 7 deletions(-) diff --git a/src/Plugin.Maui.Audio/AudioRecorder/IAudioRecorder.shared.cs b/src/Plugin.Maui.Audio/AudioRecorder/IAudioRecorder.shared.cs index 8cf5403..5bde71a 100644 --- a/src/Plugin.Maui.Audio/AudioRecorder/IAudioRecorder.shared.cs +++ b/src/Plugin.Maui.Audio/AudioRecorder/IAudioRecorder.shared.cs @@ -39,7 +39,6 @@ public interface IAudioRecorder ///The audio recording options. public Task StartAsync(string filePath, AudioRecordingOptions options) => Task.CompletedTask; - /// /// Stop recording and return the instance with the recording data. /// diff --git a/src/Plugin.Maui.Audio/AudioRecordingOptions.cs b/src/Plugin.Maui.Audio/AudioRecordingOptions.cs index 019f6f5..a060a9d 100644 --- a/src/Plugin.Maui.Audio/AudioRecordingOptions.cs +++ b/src/Plugin.Maui.Audio/AudioRecordingOptions.cs @@ -18,9 +18,6 @@ public class AudioRecordingOptions public const ChannelType DefaultChannels = ChannelType.Mono; public const BitDepth DefaultBitDepth = BitDepth.Pcm16bit; public const Encoding DefaultEncoding = Encoding.LinearPCM; - - - /// /// Sample rate of the audio recording. /// 44,100Hz is currently the only rate that is guaranteed to work on all devices on Android, Android audio record documentation @@ -47,7 +44,4 @@ public class AudioRecordingOptions /// Gets or sets whether the functionality will thrown an exception if the configured recording options are not supported. /// public bool ThrowIfNotSupported { get; set; } = false; - - - }