Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkHandler expects numeric indices #192

Open
jhedstrom opened this issue Jun 8, 2018 · 1 comment · May be fixed by #277
Open

LinkHandler expects numeric indices #192

jhedstrom opened this issue Jun 8, 2018 · 1 comment · May be fixed by #277

Comments

@jhedstrom
Copy link
Owner

jhedstrom commented Jun 8, 2018 •
edited
Loading

This code in LinkHandler expects numeric indices

      $return[] = array(
        'options' => $options,
        'title' => $value[0],
        'uri' => $value[1],
      );

while the Drupal Extension actually allows passing in the proper entity properties:

| field_foo:uri   | http://example |
| field_foo:title | My link             |
@jonathanjfshaw
Copy link
Contributor

Yeah, the handlers have got some nasty idiosyncratic variations in how they expect properties to come to them. I had to do some awkward dancing to maintain BC on some of the field plugins.

chrisolof added a commit to chrisolof/DrupalDriver that referenced this issue Oct 15, 2024
@chrisolof
Allow D8 link handler to work with named field properties
73c4c8e 
jhedstromgh-192
@chrisolof chrisolof linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow D8 link handler to work with named field properties chrisolof/DrupalDriver
2 participants
@jhedstrom @jonathanjfshaw