Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Spring Boot 2.3 #11681

Closed
4 of 5 tasks
murdos opened this issue May 1, 2020 · 23 comments · Fixed by #11682
Closed
4 of 5 tasks

Migration to Spring Boot 2.3 #11681

murdos opened this issue May 1, 2020 · 23 comments · Fixed by #11682
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: java $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@murdos
Copy link
Contributor

murdos commented May 1, 2020

I've created spring-boot-2.3 branches on both generator-jhipster and jhipster project.
I plan to create PR against these branches to handle the multiples changes required.

Overview of the impacts (identified so far)
@rodrigocprates
Copy link

@murdos what are the plans for this PR? if you need some help, reach out to me.
I specially need a way to use MongoDB Atlas (that will be fixed on your mongobee>mongock migration)

@murdos
Copy link
Contributor Author

murdos commented May 1, 2020

@rodrigocprates : there will be a dedicated PR for mongodb, and when once Spring Boot 2.3 is released and most issues are solved, we'll coordinate to merge the spring-boot-2.3 branch in master.

Regarding mongodb, I've done the migration to mongock in a branch, but it's now waiting for mongock support of MongoDB Java Driver 4.

@mraible
Copy link
Contributor

mraible commented May 15, 2020

@atomfrede
Copy link
Member

I think we can leverage the new features for k8s deployments (graceful shutdown, liveness & readinessprobes out of box).

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Jun 1, 2020
@JesusTheHun
Copy link

JesusTheHun commented Jul 8, 2020

my company would like to give a boost on this issue but we need an invoice. How can we proceed ?

@jdubois
Copy link
Member

jdubois commented Jul 19, 2020

Hi @JesusTheHun - only sponsors https://www.jhipster.tech/sponsors/ like Okta can give bug bounties.
Our aim is to have long-term relationships with a few select companies, and your proposal is not something we anticipated. Maybe you can directly pay someone to help?

@jdubois
Copy link
Member

jdubois commented Jul 19, 2020

@murdos are you coming to JHipster Code? This could be one of our tracks?
Then @JesusTheHun this would be something very new, but maybe we could find a solution with your company sponsoring the conference track (people working on this during the conference would get a gift from your company, or something similar)

@murdos
Copy link
Contributor Author

murdos commented Jul 19, 2020

@jdubois : No, I unfortunately can't attend the conference

@jdubois
Copy link
Member

jdubois commented Jul 19, 2020

@murdos oh but you had a ticket I believe! Are you sure you can’t come? Budget for core competitors in France isn’t an issue.

@murdos
Copy link
Contributor Author

murdos commented Jul 19, 2020

@jdubois : I took a ticket for the initial date in June, but I'm not available at the new date in September.

@JesusTheHun
Copy link

hi @jdubois, it would be nice if you could recommend someone for the job.
For the JHipster Code event, we need to think about it, we are in late phase of development but did not expect to go GA this early. But we will consider it.

@jdubois
Copy link
Member

jdubois commented Jul 20, 2020

Thanks @JesusTheHun ! For working on that issue as a freelancer, @murdos you might be the best person? Otherwise maybe @avdev4j @wmarques @MathieuAA @ruddell as they are all core team members and also work as freelancers

@JesusTheHun
Copy link

JesusTheHun commented Jul 20, 2020

If one of the pinged person is interested, please email me at jonathan dot massuchetti ignorethisitsforbots at dappit dot fr, so we can discuss this. Depending on how long it requires we may not be able to fully fund the issue but at least we can contribute.

Once developed, will this be part of a release of its own (since it's a big piece) or will it be shipped only with v7.0 ?

@ksilz
Copy link

ksilz commented Jul 23, 2020

@jdubois Spring Boot 2.4 will be out in October / November. Maybe we should just wait for that release that's three months away?

@hanoisteve
Copy link

I need to use Spring Kafka 2.5. Is there a way to handle that now. My Spring Boot version is 2.1.8 or do I need to wait until Spring Boot gets upgraded in JHipster to 2.3?

@atomfrede
Copy link
Member

@hanoisteve You should update to the latest jhipster release which gives you boot 2.2.x. If you have that you can try a manual migration/upgrade to boot 2.3.x.

@mraible
Copy link
Contributor

mraible commented Aug 21, 2020

Anything I can do to help make this happen?

@avdev4j
Copy link
Contributor

avdev4j commented Sep 3, 2020

Congratulations @murdos

@mraible
Copy link
Contributor

mraible commented Sep 3, 2020

Yeehaw! Happy to see this merged. 😆

@DanielFran
Copy link
Member

Great job @murdos

@murdos murdos changed the title TODO: Migration to Spring Boot 2.3 Migration to Spring Boot 2.3 Sep 3, 2020
@jdubois
Copy link
Member

jdubois commented Sep 4, 2020

Awesome work! Don't forget the $500 bug bounty @murdos !

@salimAbdulIt
Copy link

is it actually done? Because I am trying to upgrade the monolith application and after updating, I have Spring boot 2.2.7. I use Jhipster 6.10.3. Am I missing something?

@murdos
Copy link
Contributor Author

murdos commented Oct 17, 2020

@salimAbdulIt : it's not released yet, it will be embedded in next major release (7)

@pascalgrimaud pascalgrimaud added this to the 7.0.0 milestone Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: java $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.