From e2718dc728f44fcd9041a94913f15892393a37b7 Mon Sep 17 00:00:00 2001 From: Quentin Date: Fri, 1 Nov 2024 23:14:07 +0100 Subject: [PATCH] Revert "Sonar: reactivate circular dependency rule on generated apps" --- .../sonar/sonar-fullstack-project.properties.mustache | 6 +++++- .../server/sonar/sonar-project.properties.mustache | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache index 2cd94b74456..025b74bab8e 100644 --- a/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache +++ b/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache @@ -25,7 +25,7 @@ sonar.exclusions=\ src/main/webapp/app/index.tsx,\ src/main/webapp/main.ts -sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301 +sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301,S7027 # Rule: Local variable and method parameter names should comply with a naming convention # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443) @@ -85,3 +85,7 @@ sonar.issue.ignore.multicriteria.S6564.ruleKey=typescript:S6564 # Rule: Methods should not contain selector parameters sonar.issue.ignore.multicriteria.S2301.resourceKey=src/main/webapp/app/auth/oauth2-auth.service.ts sonar.issue.ignore.multicriteria.S2301.ruleKey=typescript:S2301 + +# Rule: Circular dependencies between classes in the same package should be resolved +sonar.issue.ignore.multicriteria.S7027.resourceKey=src/**/java/**/* +sonar.issue.ignore.multicriteria.S7027.ruleKey=javaarchitecture:S7027 diff --git a/src/main/resources/generator/server/sonar/sonar-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-project.properties.mustache index e3de90dc7a4..03a406a3274 100644 --- a/src/main/resources/generator/server/sonar/sonar-project.properties.mustache +++ b/src/main/resources/generator/server/sonar/sonar-project.properties.mustache @@ -21,7 +21,7 @@ sonar.exclusions=\ src/main/webapp/app/index.tsx,\ src/main/webapp/main.ts -sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301 +sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301,S7027 # Rule: Local variable and method parameter names should comply with a naming convention # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443) @@ -85,3 +85,7 @@ sonar.issue.ignore.multicriteria.S6471.ruleKey=docker:S6471 # Rule: Methods should not contain selector parameters sonar.issue.ignore.multicriteria.S2301.resourceKey=src/main/webapp/app/auth/oauth2-auth.service.ts sonar.issue.ignore.multicriteria.S2301.ruleKey=typescript:S2301 + +# Rule: Circular dependencies between classes in the same package should be resolved +sonar.issue.ignore.multicriteria.S7027.resourceKey=src/**/java/**/* +sonar.issue.ignore.multicriteria.S7027.ruleKey=javaarchitecture:S7027