Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export with higher resolution #110

Open
EdJoPaTo opened this issue Mar 1, 2022 · 1 comment
Open

Export with higher resolution #110

EdJoPaTo opened this issue Mar 1, 2022 · 1 comment

Comments

@EdJoPaTo
Copy link
Contributor

EdJoPaTo commented Mar 1, 2022

I tried to export a recording with higher resolution as some fonts can be quite small in screen sharings. Simply adapting the width/height variables and xvfb args (as seen below) change the resolution internally (elements are larger/smaller) but the final video resolution seems to stay the same.

bbb-recorder/export.js

Lines 12 to 15 in 7f3ef44

xvfb_args: ["-screen", "0", "1280x800x24", "-ac", "-nolisten", "tcp", "-dpi", "96", "+extension", "RANDR"]
});
var width = 1280;
var height = 720;

I haven't found out where or how I might be able to change that. I assume that might be easy when knowing where to look and I just looked at the wrong places.


For someone else looking into it: I changed the linked source code towards the following as its nicer to edit but it does technically the same.

+var width = 1280;
+var height = 720;
 var xvfb = new Xvfb({
     silent: true,
-    xvfb_args: ["-screen", "0", "1280x800x24", "-ac", "-nolisten", "tcp", "-dpi", "96", "+extension", "RANDR"]
+    xvfb_args: ["-screen", "0", `${width}x${height + 80}x24`, "-ac", "-nolisten", "tcp", "-dpi", "96", "+extension", "RANDR"]
 });
-var width = 1280;
-var height = 720;
@ddean4040
Copy link

Hi @EdJoPaTo - you also need to increase the resolution of the browser in background.js. Here are settings we used to make small text legible:

                                chromeMediaSourceId: streamId,
-                                minWidth: 1280,
-                                maxWidth: 1280,
-                                minHeight: 720,
-                                maxHeight: 720,
-                                minFrameRate: 60,
+                                minWidth: 1920,
+                                maxWidth: 1920,
+                                minHeight: 1080,
+                                maxHeight: 1080,
+                                minFrameRate: 30,
                            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants