-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor task - use Ubuntu Mantic for clang-format
versions 13 through 16
#165
Comments
@Xav83 if you're looking for some more low-hanging fruit for Hacktoberfest, feel free to take a swing at this ☝️ |
Hi,Can you assign this to me? |
Sure thing, thanks @Ajeets6 ! |
@jidicula it seems like this image change wasn't entirely backwards compatible for our simple use case:
Could you revert this change and then push it out again but with a new tag? That at least gives people the ability to opt into it |
@danperkins sorry about that! I've reverted the change in #167 and merged it, so the new images will be built and shipping shortly and your workflows will start functioning again. What was the specific issue you were seeing with your use-case? |
@jidicula thanks for the quick response! Someone from our team is working through the formatting changes now so that we can move to the new version before too long. It seems like it was just caused by us having the formatting and linting happing in slightly different pipelines. Clang was unhappy with some of the spacing/tabs in our files after the change. I guess we could have tried rolling back to |
Ubuntu Mantic also contains
clang-format
versions 13 through 16. As much as possible, I prefer to reduce the number of Ubuntu versions I'm shipping in my Docker images. Switching versions 13 through 16 to Mantic would allow me to drop the Lunar dependency.This task is fairly simple - in these lines, switch the Ubuntu version to
mantic
to match version 17.The text was updated successfully, but these errors were encountered: