Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non zero exit code from a custom command building install step in jitpack.yml is ignored #6762

Closed
vorburger opened this issue Dec 29, 2024 · 2 comments
Labels

Comments

@vorburger
Copy link

Inspired by #3129,

I'm working on published my https://bazel.build -based project on JitPack in enola-dev/enola#970,

and found what to me appears to be a (minor) but in JitPack's error handling of Non zero exit code from a custom command building install step:

Given this jitpack.yml,

which make JitPack invoke this script,

causes https://.io/com/github/enola-dev/enola/d9fcbc02fb/build.log, copy/pasted here for preservation:

Running install command:
tools/maven/install.bash
+ bazelisk build //java/dev/enola
tools/maven/install.bash: line 22: bazelisk: command not found
Build tool exit code: 0
Looking for artifacts...
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Looking for pom.xml in build directory and ~/.m2
Found artifact: dev.enola:enola:1.0.0-SNAPSHOT
2024-12-29T18:40:38.167527864Z
Exit code: 0

That doesn't sound right, to me... if bazelisk: command not found, then it wasn't (should be) exit code: 0... agreed?

PS: I'm only filing this issue to report a sub-optimal error handling. I'll separately fix the actual issue of installing the missing https://github.com/bazelbuild/bazelisk.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 29, 2025
@jitpack-io jitpack-io added bug and removed stale labels Jan 29, 2025
@jitpack-io
Copy link
Member

Thank you for reporting!
We have rolled out a fix for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants