Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeserver domain sometimes don't stay saved in settings pane #454

Open
danmanrana opened this issue Oct 3, 2020 · 4 comments
Open

Homeserver domain sometimes don't stay saved in settings pane #454

danmanrana opened this issue Oct 3, 2020 · 4 comments

Comments

@danmanrana
Copy link

On Ubuntu Desktop 20.04, app v2.4.1.

@saghul
Copy link
Member

saghul commented Oct 3, 2020

Does it happen if you focus some other field before closing the panel?

@danmanrana
Copy link
Author

If I click the faded blue to the right of the panel causing the settings pane to close, it stays, but not when I hit the back arrow.

@Freddie-m
Copy link

Any update on this? Just experienced the issue on the latest version (Windows build). None of the information entered in the text fields commit when the drawer is closed using the back arrow.

@herebebeasties
Copy link

This is because it is only submitted on the blur event, which I guess isn't happening when you hit the back arrow, for whatever reason.

Suggested fix: Update it onChange instead (with the validity check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants