-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium 123 added support for desktop soundsharing on linux! 🚀🚀 #945
Comments
Once there is an Electron release with that base Chromium we'll get the feature as part of the usual updates we do. Thanks for sharing! |
And that would be Electron 30 which will come mid of April with Chromium 124: https://github.com/electron/electron/blob/main/docs/tutorial/electron-timelines.md |
The day has come people, remember to close the issue as completed when you update to electron 30! |
Contains electron 30 update, for details see https://www.electronjs.org/blog/electron-30-0 Fixes: #945
Contains electron 30 update, for details see https://www.electronjs.org/blog/electron-30-0 Fixes: #945
Looking at electron/electron#10515 it seems that some electron bits might also be required to get this to work. And then its gated to windows on the frontend as well, at the moment: https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34 So reopening this issue :) |
I know for certain that in vanilla chromium/chrome/brave you need to set #pulseaudio-loopback-for-cast and #pulseaudio-loopback-for-screen-share to get it to work, so maybe there are extra steps in achieving this in the electron app too? :D. |
Oh we actually have to wait for electron to support it separately, I see. Well no big deal, will manage with vanilla chromium till then! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This ain't stale! There is progress on this issue, as recently even discord added this functionality. Patience! |
Electron doesn't AFAIK. |
It's funny that zoom has supported this since ages ago, discord now supports it and electron still lags behind. But anyways, a year later my statement remains the same, since it works fine when using jitsi from chromium, I can wait. For anyone reading this with the same issue just install vanilla chromium and add jitsi as a webapp. Uncertain if you still need to mess with some configs but you can find more if you search online. |
I could say it's funny that those are closed source and Electron isn't. Those comparisons don't help anyone. |
I am not bashing on anyone and I am sorry if my comment was interpreted as such. I too was referring to the fact that they are both closed source. Usually support in proprietary software comes last(e.g, the whole screen sharing situation on Wayland all these years), but here the situation is altered. Hope that clears it up! |
Hello!
Finally, this very desirable feature for some of us has been added, as a matter of fact using ChromeDev I tested it and found it to be (mostly) working! Can expect the few issues here and there to be fixed by the time it reaches the stable branch.
I am opening this issue because I am unfamiliar with the development of electron apps or even this particular app, to ask when can we expect this feature to land after it has landed in chromium's stable branch. Will it be as soon as possible or is there anything that has you holding back chromium's version?
Thanks in advance!
F.
Relevant link: https://issues.chromium.org/issues/40155218
Note: You can test it yourself using flathub's ChromeDev
The text was updated successfully, but these errors were encountered: