Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bouncycastle from 1.48 to 1.64 #3

Closed
wants to merge 1 commit into from

Conversation

annatindall
Copy link

No description provided.

@damencho
Copy link
Member

Have you tested this change incorporated with libjitsi and in Jitsi Desktop? Do calls succeed with and without zrtp, sip and xmpp?

@annatindall
Copy link
Author

Thanks for your quick response! We've tested sip calls both with and without zrtp using our application, which was originally forked from Jitsi Desktop. To get this change to work with Jitsi Desktop, you'd need to update its version of BouncyCastle as well.
I don't quite understand what xmpp testing you're referring to - please could you clarify?

@damencho
Copy link
Member

Xmpp audio/video calls. But if sip srtp calls work should be ok...

@annatindall
Copy link
Author

As far as I know, we don't support xmpp audio/video calls so that would be difficult for us to test.

@annatindall
Copy link
Author

@Neustradamus Sorry, we don't have the testing budget to upgrade to 1.65 right now, but will take a look next time we update dependent libraries if ibauersachs doesn't get there first

@Neustradamus
Copy link

@annatindall: Yes in first, it is possible to merge for 1.64 :)
@damencho, @ibauersachs: What do you think?

@Neustradamus
Copy link

@ibauersachs: Solved?

@ibauersachs
Copy link
Member

@Neustradamus
Copy link

@ibauersachs: Thanks a lot, Jitsi project progress!

It was not specified in this ticket: Closed and solved by @ibauersachs in bcf44f0#diff-600376dffeb79835ede4a0b285078036.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants